[PATCH 2/2] builtin-tag: fix uninitialized variables

Johannes Schindelin· Jul 20, 2007, 12:07 UTC · lore

The function launch_editor() expects the variables 'buffer' and 'size' to be initialized, either to an existing buffer, or to NULL and 0.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
	This is only called 2/2, because I found this error by testing 
	1/2...

 builtin-tag.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Show changes to builtin-tag.c +2 −2

diff --git a/builtin-tag.c b/builtin-tag.c
index cf36def..81d37ce 100644
--- a/builtin-tag.c
+++ b/builtin-tag.c
@@ -253,9 +253,9 @@ static void create_tag(const unsigned char *object, const char *tag,
 		       char *message, int sign, unsigned char *result)
 {
 	enum object_type type;
-	char header_buf[1024], *buffer;
+	char header_buf[1024], *buffer = NULL;
 	int header_len, max_size;
-	unsigned long size;
+	unsigned long size = 0;
 
 	type = sha1_object_info(object, NULL);
 	if (type <= 0)

-- 
1.5.3.rc1.16.g9d6f-dirty

patch, 2 partsbuiltin-tag: fix uninitialized variables