threads / patch / 9050

patchRevert 'Disallow non-patch args to "stg show" (gna #8453).'

Subject: [StGIT PATCH] Revert 'Disallow non-patch args to "stg show" (gna #8453).'

## tl;dr

One message between Jul 15, 2007 and Jul 15, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Yann Dirson· Jul 15, 2007, 21:32 UTC · lore

This patch has a lot of side-effects that will break people's expectations. There is much more that just this to do if we want to sanitize patch/commit/range addressing on the command-line, so that will wait till after 0.13.

Signed-off-by: Yann Dirson <ydirson@altern.org>
---
 stgit/commands/show.py |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
Show changes to stgit/commands/show.py +6 −1
diff --git a/stgit/commands/show.py b/stgit/commands/show.py
index 2b22744..45ca253 100644
--- a/stgit/commands/show.py
+++ b/stgit/commands/show.py
@@ -55,7 +55,12 @@ def func(parser, options, args):
     elif len(args) == 0:
         patches = ['HEAD']
     else:
-        patches = parse_patches(args, applied + unapplied +\
+        if len(args) == 1 and args[0].find('..') == -1 \
+               and not crt_series.patch_exists(args[0]):
+            # it might be just a commit id
+            patches = args
+        else:
+            patches = parse_patches(args, applied + unapplied +\
                                 crt_series.get_hidden(), len(applied))
 
     if options.diff_opts:

← back to recent threads