# [PATCH] make git-send-email.perl handle email addresses with no names when Email::Valid is present 7 messages from 2007-07-13 to 2007-08-09. Participants: Greg KH, Junio C Hamano, Stephen Rothwell, Uwe Kleine-König. Thread: https://gitlist.dev/t/9016 ## Greg KH, 2007-07-13 04:17 Subject: [PATCH] make git-send-email.perl handle email addresses with no names when Email::Valid is present Message-ID: <20070713041749.GA28824@kroah.com> URL: https://gitlist.dev/e/20070713041749.GA28824%40kroah.com ``` When using git-send-email.perl on a changeset that has: Cc: in the body of the description, and the Email::Valid perl module is installed on the system, the email address will be deemed "invalid" for some reason (Email::Valid isn't smart enough to handle this?) and complain and not send the address the email. Anyway, this tiny patch fixes this problem for me. Note, my perl-foo is quite week, so this could probably be easily done in one line for those with better reg-ex skills. Signed-off-by: Greg Kroah-Hartman --- a/git-send-email.perl +++ b/git-send-email.perl @@ -410,6 +410,9 @@ sub extract_valid_address { return $address if ($address =~ /^($local_part_regexp)$/); if ($have_email_valid) { + if ($address =~ s/^$//; + } return scalar Email::Valid->address($address); } else { # less robust/correct than the monster regexp in Email::Valid, ``` ## Junio C Hamano, 2007-07-13 05:47 Subject: Re: [PATCH] make git-send-email.perl handle email addresses with no names when Email::Valid is present Message-ID: <7vr6ncrh22.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vr6ncrh22.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20070713041749.GA28824@kroah.com> ``` Greg KH writes: > When using git-send-email.perl on a changeset that has: > Cc: > in the body of the description, and the Email::Valid perl module is > installed on the system, the email address will be deemed "invalid" for > some reason (Email::Valid isn't smart enough to handle this?) and > complain and not send the address the email. That appears to be the case. bad foo bad ok foo@bar.baz ok Foo > Anyway, this tiny patch fixes this problem for me. Note, my perl-foo is > quite week, so this could probably be easily done in one line for those > with better reg-ex skills. > --- a/git-send-email.perl > +++ b/git-send-email.perl > @@ -410,6 +410,9 @@ sub extract_valid_address { > return $address if ($address =~ /^($local_part_regexp)$/); > > if ($have_email_valid) { > + if ($address =~ s/^ + $address =~ s/>$//; > + } > return scalar Email::Valid->address($address); > } else { I'd probably do: if ($have_email_valid) { $address =~ s/^<(.*)>$/$1/; return scalar Email::Valid->address($address); } else { instead, but they are moral equivalents. Thanks for a fix. ``` ## Greg KH, 2007-07-13 06:34 Subject: Re: [PATCH] make git-send-email.perl handle email addresses with no names when Email::Valid is present Message-ID: <20070713063414.GN24317@kroah.com> URL: https://gitlist.dev/e/20070713063414.GN24317%40kroah.com In-Reply-To: <7vr6ncrh22.fsf@assigned-by-dhcp.cox.net> ``` On Thu, Jul 12, 2007 at 10:47:17PM -0700, Junio C Hamano wrote: > Greg KH writes: > > > When using git-send-email.perl on a changeset that has: > > Cc: > > in the body of the description, and the Email::Valid perl module is > > installed on the system, the email address will be deemed "invalid" for > > some reason (Email::Valid isn't smart enough to handle this?) and > > complain and not send the address the email. > > That appears to be the case. > > bad foo > bad > ok foo@bar.baz > ok Foo > > > Anyway, this tiny patch fixes this problem for me. Note, my perl-foo is > > quite week, so this could probably be easily done in one line for those > > with better reg-ex skills. > > > --- a/git-send-email.perl > > +++ b/git-send-email.perl > > @@ -410,6 +410,9 @@ sub extract_valid_address { > > return $address if ($address =~ /^($local_part_regexp)$/); > > > > if ($have_email_valid) { > > + if ($address =~ s/^ > + $address =~ s/>$//; > > + } > > return scalar Email::Valid->address($address); > > } else { > > I'd probably do: > > if ($have_email_valid) { > $address =~ s/^<(.*)>$/$1/; Ah, yeah, that looks better :) Thanks for the fix, greg k-h ``` ## Stephen Rothwell, 2007-07-13 08:28 Subject: Re: [PATCH] make git-send-email.perl handle email addresses with no names when Email::Valid is present Message-ID: <20070713182818.fd37372f.sfr@canb.auug.org.au> URL: https://gitlist.dev/e/20070713182818.fd37372f.sfr%40canb.auug.org.au In-Reply-To: <20070713063414.GN24317@kroah.com> ``` On Thu, 12 Jul 2007 23:34:14 -0700 Greg KH wrote: > > On Thu, Jul 12, 2007 at 10:47:17PM -0700, Junio C Hamano wrote: > > Greg KH writes: > > > > > When using git-send-email.perl on a changeset that has: > > > Cc: > > > in the body of the description, and the Email::Valid perl module is > > > installed on the system, the email address will be deemed "invalid" for > > > some reason (Email::Valid isn't smart enough to handle this?) and > > > complain and not send the address the email. > > > > That appears to be the case. > > > > bad foo > > bad > > ok foo@bar.baz > > ok Foo This would be a bug in Email::Valid as it complains that the second address fails the rfc822 check, however rfc822 says that the "display name" before the '<' is optional. > > I'd probably do: > > > > if ($have_email_valid) { > > $address =~ s/^<(.*)>$/$1/; $address =~ s/^\s*<(.*)>\s*$/$1/; -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ ``` ## Greg KH, 2007-07-14 04:00 Subject: Re: [PATCH] make git-send-email.perl handle email addresses with no names when Email::Valid is present Message-ID: <20070714040050.GA11773@kroah.com> URL: https://gitlist.dev/e/20070714040050.GA11773%40kroah.com In-Reply-To: <20070713182818.fd37372f.sfr@canb.auug.org.au> ``` On Fri, Jul 13, 2007 at 06:28:18PM +1000, Stephen Rothwell wrote: > On Thu, 12 Jul 2007 23:34:14 -0700 Greg KH wrote: > > > > On Thu, Jul 12, 2007 at 10:47:17PM -0700, Junio C Hamano wrote: > > > Greg KH writes: > > > > > > > When using git-send-email.perl on a changeset that has: > > > > Cc: > > > > in the body of the description, and the Email::Valid perl module is > > > > installed on the system, the email address will be deemed "invalid" for > > > > some reason (Email::Valid isn't smart enough to handle this?) and > > > > complain and not send the address the email. > > > > > > That appears to be the case. > > > > > > bad foo > > > bad > > > ok foo@bar.baz > > > ok Foo > > This would be a bug in Email::Valid as it complains that the second > address fails the rfc822 check, however rfc822 says that the "display > name" before the '<' is optional. I agree, do you know how to get such a fix made? thanks, greg k-h ``` ## Stephen Rothwell, 2007-07-14 10:38 Subject: Re: [PATCH] make git-send-email.perl handle email addresses with no names when Email::Valid is present Message-ID: <20070714203842.bf6c43cc.sfr@canb.auug.org.au> URL: https://gitlist.dev/e/20070714203842.bf6c43cc.sfr%40canb.auug.org.au In-Reply-To: <20070714040050.GA11773@kroah.com> ``` On Fri, 13 Jul 2007 21:00:50 -0700 Greg KH wrote: > > On Fri, Jul 13, 2007 at 06:28:18PM +1000, Stephen Rothwell wrote: > > > > This would be a bug in Email::Valid as it complains that the second > > address fails the rfc822 check, however rfc822 says that the "display > > name" before the '<' is optional. > > I agree, do you know how to get such a fix made? I would be inclined to make it my distribution's problem :-) i.e. on Debian I would report a bug against libemail-valid-perl. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ ``` ## Uwe Kleine-König, 2007-08-09 12:28 Subject: Re: [PATCH] make git-send-email.perl handle email addresses with no names when Email::Valid is present Message-ID: <20070809122859.GA5130@cassiopeia> URL: https://gitlist.dev/e/20070809122859.GA5130%40cassiopeia In-Reply-To: <20070713041749.GA28824@kroah.com> ``` Hello, Greg KH wrote: > When using git-send-email.perl on a changeset that has: > Cc: > in the body of the description, and the Email::Valid perl module is > installed on the system, the email address will be deemed "invalid" for > some reason (Email::Valid isn't smart enough to handle this?) and > complain and not send the address the email. The reason is probably that it is indeed invalid. From rfc822: mailbox = addr-spec / phrase route-addr addr-spec = local-part "@" domain phrase = 1*word word = atom / quoted-string atom = 1* quoted-string = <"> *(qtext/quoted-pair) <"> route-addr = "<" [route] addr-spec ">" ... where 1* means "at least one of". That is, either you must not use <...> or you need a non-empty phrase. Actually this grammar looks wrong, because as I read it it would not allow spaces between words in phrase. But that's another issue. BTW: Outlook depends on this, because if you use Cc: , it doesn't show anything in the Cc: line---at least in the default configuration. So I suggest the following: ---- >8 ---- send-email: rfc822 forbids using without a non-empty "phrase" Email::Valid does respect this considering such a mailbox specification invalid. b06c6bc831cbb9e9eb82fd3ffd5a2b674cd940d0 addressed the issue, but only if Email::Valid is available. Signed-off-by: Uwe Kleine-König --- git-send-email.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index 39e433b..a02ab96 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -408,8 +408,8 @@ sub extract_valid_address { # check for a local address: return $address if ($address =~ /^($local_part_regexp)$/); + $address =~ s/^\s*<(.*)>\s*$/$1/; if ($have_email_valid) { - $address =~ s/^\s*<(.*)>\s*$/$1/; return scalar Email::Valid->address($address); } else { # less robust/correct than the monster regexp in Email::Valid, -- 1.5.3.rc3.943.g14c81 -- Uwe Kleine-König If a lawyer and an IRS agent were both drowning, and you could only save one of them, would you go to lunch or read the paper? ```