threads / discuss / 8959

Per-file, possibly even per-hunk cherry picking

Subject: Per-file, possibly even per-hunk cherry picking

## tl;dr

5 messages between Jul 10, 2007 and Jul 11, 2007.

replies: 4people: 3as markdown or json

Sam Vilain· Jul 10, 2007, 12:16 UTC · lore
Hi all,

I'm interested in extending the cherry analysis to allow specification of the diff options used when calculating diff IDs, presenting the calculated diff IDs for analysis by external tools, and even calculating and dealing with per-hunk diff IDs.

Has anyone done anything with this before, or got any good pointers or advice?

Sam.
Sam Vilain· Jul 10, 2007, 12:48 UTC · re: Sam Vilain · lore

Re: Per-file, possibly even per-hunk cherry picking

Sam Vilain wrote:
Show 5 quoted lines
> I'm interested in extending the cherry analysis to allow specification
> of the diff options used when calculating diff IDs, presenting the
> calculated diff IDs for analysis by external tools, and even calculating
> and dealing with per-hunk diff IDs.
>

On reflection I think so long as --cherry-pick works together with a file selection, it would probably be enough.

ie, if I have these commits:
A---B
 \
  \
   C

B changes a file foo.c, adding a line of text. C changes foo.c as well as bar.c, but the change in foo.c was identical to change B.

I want this to show me nothing:
  git-rev-list --left-right --cherry-pick B...C -- foo.c

Would it be the right approach to put this information in ids->diffopts, or somewhere else?

Sam.
Johannes Schindelin· Jul 10, 2007, 13:50 UTC · re: Sam Vilain · lore

[PATCH] Fix --cherry-pick with given paths

If you say --cherry-pick, you do not want to see patches which are in the upstream. If you specify paths with that, what you usually expect is that only those parts of the patches are looked at which actually touch the given paths.

With this patch, that expectation is met.
Noticed by Sam Vilain.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
	On Wed, 11 Jul 2007, Sam Vilain wrote:
	> Sam Vilain wrote:
	> > I'm interested in extending the cherry analysis to allow 
	> > specification of the diff options used when calculating diff 
	> > IDs, presenting the calculated diff IDs for analysis by 
	> > external tools, and even calculating and dealing with per-hunk 
	> > diff IDs.
	> 
	> On reflection I think so long as --cherry-pick works together 
	> with a file selection, it would probably be enough.
	> 
	> ie, if I have these commits:
	> 
	> A---B
	>  \
	>   \
	>    C
	> 
	> B changes a file foo.c, adding a line of text.  C changes foo.c 
	> as well as bar.c, but the change in foo.c was identical to 
	> change B.
	> 
	> I want this to show me nothing:
	> 
	>   git-rev-list --left-right --cherry-pick B...C -- foo.c
	> 
	> Would it be the right approach to put this information in 
	> ids->diffopts, or somewhere else?
	That was interesting.  And it is indeed the right place to put it.
 revision.c                           |    9 +++++-
 t/t6007-rev-list-cherry-pick-file.sh |   43 ++++++++++++++++++++++++++++++++++
 2 files changed, 50 insertions(+), 2 deletions(-)
 create mode 100755 t/t6007-rev-list-cherry-pick-file.sh
diff --git a/revision.c b/revision.c
index 33ee9ee..27cce09 100644
--- a/revision.c
+++ b/revision.c
@@ -437,7 +437,7 @@ static int add_parents_to_list(struct rev_info *revs, struct commit *commit, str
 	return 0;
 }
 
-static void cherry_pick_list(struct commit_list *list)
+static void cherry_pick_list(struct commit_list *list, struct rev_info *revs)
 {
 	struct commit_list *p;
 	int left_count = 0, right_count = 0;
@@ -458,6 +458,11 @@ static void cherry_pick_list(struct commit_list *list)
 
 	left_first = left_count < right_count;
 	init_patch_ids(&ids);
+	if (revs->diffopt.nr_paths) {
+		ids.diffopts.nr_paths = revs->diffopt.nr_paths;
+		ids.diffopts.paths = revs->diffopt.paths;
+		ids.diffopts.pathlens = revs->diffopt.pathlens;
+	}
 
 	/* Compute patch-ids for one side */
 	for (p = list; p; p = p->next) {
@@ -546,7 +551,7 @@ static int limit_list(struct rev_info *revs)
 		p = &commit_list_insert(commit, p)->next;
 	}
 	if (revs->cherry_pick)
-		cherry_pick_list(newlist);
+		cherry_pick_list(newlist, revs);
 
 	revs->commits = newlist;
 	return 0;
diff --git a/t/t6007-rev-list-cherry-pick-file.sh b/t/t6007-rev-list-cherry-pick-file.sh
new file mode 100755
index 0000000..143f332
--- /dev/null
+++ b/t/t6007-rev-list-cherry-pick-file.sh
@@ -0,0 +1,43 @@
+#!/bin/sh
+
+test_description='test git rev-list --cherry-pick -- file'
+
+. ./test-lib.sh
+
+# A---B
+#  \
+#   \
+#    C
+# 
+# B changes a file foo.c, adding a line of text.  C changes foo.c as
+# well as bar.c, but the change in foo.c was identical to change B.
+
+test_expect_success setup '
+	echo Hallo > foo &&
+	git add foo &&
+	test_tick &&
+	git commit -m "A" &&
+	git tag A &&
+	git checkout -b branch &&
+	echo Bello > foo &&
+	echo Cello > bar &&
+	git add foo bar &&
+	test_tick &&
+	git commit -m "C" &&
+	git tag C &&
+	git checkout master &&
+	git checkout branch foo &&
+	test_tick &&
+	git commit -m "B" &&
+	git tag B
+'
+
+test_expect_success '--cherry-pick foo comes up empty' '
+	test -z "$(git rev-list --left-right --cherry-pick B...C -- foo)"
+'
+
+test_expect_success '--cherry-pick bar does not come up empty' '
+	! test -z "$(git rev-list --left-right --cherry-pick B...C -- bar)"
+'
+
+test_done

-- 
1.5.3.rc0.2782.g192a9-dirty
Sam Vilain· Jul 10, 2007, 14:22 UTC · re: Johannes Schindelin · lore

Re: [PATCH] Fix --cherry-pick with given paths

Johannes Schindelin wrote:
Show 11 quoted lines
> If you say --cherry-pick, you do not want to see patches which are
> in the upstream.  If you specify paths with that, what you usually
> expect is that only those parts of the patches are looked at which
> actually touch the given paths.
>
> With this patch, that expectation is met.
>
> Noticed by Sam Vilain.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>   
I just tested this, and it seems to work just like I hoped, so:
Signed-off-by: Sam Vilain <sam.vilain@catalyst.net.nz>
Sam.
Junio C Hamano· Jul 11, 2007, 22:00 UTC · re: Johannes Schindelin · lore

Re: [PATCH] Fix --cherry-pick with given paths

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 24 quoted lines
> 	> Sam Vilain wrote:
> 	> > I'm interested in extending the cherry analysis to allow 
> 	> > specification of the diff options used when calculating diff 
> 	> > IDs, presenting the calculated diff IDs for analysis by 
> 	> > external tools, and even calculating and dealing with per-hunk 
> 	> > diff IDs.
> 	> 
> 	> On reflection I think so long as --cherry-pick works together 
> 	> with a file selection, it would probably be enough.
> 	> 
> 	> ie, if I have these commits:
> 	> 
> 	> A---B
> 	>  \
> 	>   \
> 	>    C
> 	> 
> 	> B changes a file foo.c, adding a line of text.  C changes foo.c 
> 	> as well as bar.c, but the change in foo.c was identical to 
> 	> change B.
> 	> 
> 	> I want this to show me nothing:
> 	> 
> 	>   git-rev-list --left-right --cherry-pick B...C -- foo.c
Thanks, both.

← back to recent threads