threads / patch / 8870

patchgitk: Fix for tree view ending in nested directories

Subject: [PATCH] gitk: Fix for tree view ending in nested directories

## tl;dr

One message between Jul 4, 2007 and Jul 4, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Brian Downing· Jul 4, 2007, 21:26 UTC · lore

Unroll the prefix stack when assigning treeheights when leaving proc treeview. Previously, when the ls-tree output ended in multiple nested directories (for instance in a repository with a single file "foo/bar/baz"), $treeheight("foo/bar/") was assigned twice, and $treeheight("foo/") was never assigned. This led to an error when expanding the "foo" directory in the gitk treeview.

Signed-off-by: Brian Downing <bdowning@lavos.net>
---
 gitk |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Show changes to gitk +3 −0
diff --git a/gitk b/gitk
index 2d6a6ef..d94c512 100755
--- a/gitk
+++ b/gitk
@@ -1216,6 +1216,9 @@ proc treeview {w l openlevs} {
 	set treeheight($prefix) $ht
 	incr ht [lindex $htstack end]
 	set htstack [lreplace $htstack end end]
+	set prefixend [lindex $prefendstack end]
+	set prefendstack [lreplace $prefendstack end end]
+	set prefix [string range $prefix 0 $prefixend]
     }
     $w conf -state disabled
 }
-- 
1.5.2.GIT

← back to recent threads