threads / discuss / 8849

gitk - fails to highlight commits

Subject: gitk - fails to highlight commits

## tl;dr

3 messages between Jul 4, 2007 and Jul 4, 2007.

replies: 2people: 2as markdown or json

Mark Levedahl· Jul 4, 2007, 00:44 UTC · lore

Using gitk on master (281404ca1db4c921ac162f3c0 in the gitk) gitk's highlighting is sporadic. Running gitk from a gitk sandbox and typing 'gitk' into the 'Highlight Commits' box shows nothing highlighted, but all commits should be highlighted. After doing this, many of the commits revealed by scrolling down the list are highlighted, just not the ones visisble at the top nor the first few below.

This problem first appears in commit 322a8cc ("gitk: New algorithm for drawing the graph lines).

Mark

Paul Mackerras· Jul 4, 2007, 12:02 UTC · re: Mark Levedahl · lore

Re: gitk - fails to highlight commits

Mark Levedahl writes:

Show 6 quoted lines

> Using gitk on master (281404ca1db4c921ac162f3c0 in the gitk) gitk's 
> highlighting is sporadic. Running gitk from a gitk sandbox and typing 
> 'gitk' into the 'Highlight Commits' box shows nothing highlighted, but 
> all commits should be highlighted. After doing this, many of the commits 
> revealed by scrolling down the list are highlighted, just not the ones 
> visisble at the top nor the first few below.

This is fixed by a commit I just pushed out ("gitk: Fix the find and highlight functions").

Paul.

Mark Levedahl· Jul 4, 2007, 13:34 UTC · re: Paul Mackerras · lore

Re: gitk - fails to highlight commits

Paul Mackerras wrote:

Show 5 quoted lines

> This is fixed by a commit I just pushed out ("gitk: Fix the find and
> highlight functions").
>
> Paul.
>

Thanks - that fixed the problem.

Mark