t9400-git-cvsserver-server failures

I'm getting several failures in the git-cvsserver tests. I don't even know where to start with that code, so here's as detailed an error report as I can give.

The first category appears to be that several of the tests use test_expect_failure, which expects the error codes to be less than 127 and the error it gets is 255 (-1).

* FAIL 9: req_Root failure (strict-paths)
         cat request-anonymous | git-cvsserver --strict-paths pserver  
$WORKDIR >log 2>&1
* FAIL 11: req_Root failure (w/o strict-paths)
         cat request-anonymous | git-cvsserver pserver $WORKDIR/ 
gitcvs >log 2>&1
* FAIL 13: req_Root failure (base-path)
         cat request-anonymous | git-cvsserver --strict-paths --base- 
path $WORKDIR pserver $SERVERDIR >log 2>&1

The other seems to be that git-cvsserver is erroring with "error 1 Conflicting roots specified" unexpectedly. The log has the expected "I LOVE YOU" line, but then also has an error line.

* FAIL 12: req_Root (base-path)
         cat request-base | git-cvsserver --strict-paths --base-path  
$WORKDIR/ pserver $SERVERDIR >log 2>&1 &&
            tail -n1 log | grep -q "^I LOVE YOU$"
* FAIL 16: req_Root (everything together)
         cat request-base | git-cvsserver --export-all --strict-paths  
--base-path $WORKDIR/ pserver $SERVERDIR >log 2>&1 &&
            tail -n1 log | grep -q "^I LOVE YOU$"

And, finally, one test fails because apparently the environment is not set up as it expects.

* FAIL 14: req_Root (export-all)
         cat request-anonymous | git-cvsserver --export-all pserver  
$WORKDIR >log 2>&1 &&
            tail -n1 log | grep -q "^I LOVE YOU$"

This fails with:

E GITCVS emulation needs to be enabled on this repo E the repo config file needs a [gitcvs] section added, and the parameter 'enabled' set to 1 E error 1 GITCVS emulation disabled E Invalid root /Users/brian/dev/git/t/trash/gitcvs.git

I checked gitcvs.git/config, and it has "[gitcvs] enabled = false".

~~ Brian

On Jun 26, 2007, at 11:07 PM, Brian Gernhardt wrote:

Running the tests again this morning after a fresh pull results in only the above failures occurring. I looked through git- cvsserver.perl and couldn't find any exit(-1) or similar. Anyone have any idea where to start to fix these?

~~ Brian

On Wed, Jun 27, 2007 at 09:08:16AM -0400, Brian Gernhardt wrote:

Look for "die", it exits with such an error code by default. Will try to look into the issues later.

Gruesse,