threads / patch / 8642

patchmake dist: include configure script in tarball

Subject: [PATCH] make dist: include configure script in tarball

## tl;dr

5 messages between Jun 18, 2007 and Jun 19, 2007. Diffs are folded; open one to read it.

replies: 4people: 4as markdown or json

Matthias Lederhofer· Jun 18, 2007, 21:30 UTC · lore
Signed-off-by: Matthias Lederhofer <matled@gmx.net>
---
 Makefile |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Show changes to Makefile +3 −2
diff --git a/Makefile b/Makefile
index 0f75955..9b7efcf 100644
--- a/Makefile
+++ b/Makefile
@@ -1009,15 +1009,16 @@ git.spec: git.spec.in
 	mv $@+ $@
 
 GIT_TARNAME=git-$(GIT_VERSION)
-dist: git.spec git-archive
+dist: git.spec git-archive configure
 	./git-archive --format=tar \
 		--prefix=$(GIT_TARNAME)/ HEAD^{tree} > $(GIT_TARNAME).tar
 	@mkdir -p $(GIT_TARNAME)
-	@cp git.spec $(GIT_TARNAME)
+	@cp git.spec configure $(GIT_TARNAME)
 	@echo $(GIT_VERSION) > $(GIT_TARNAME)/version
 	@$(MAKE) -C git-gui TARDIR=../$(GIT_TARNAME)/git-gui dist-version
 	$(TAR) rf $(GIT_TARNAME).tar \
 		$(GIT_TARNAME)/git.spec \
+		$(GIT_TARNAME)/configure \
 		$(GIT_TARNAME)/version \
 		$(GIT_TARNAME)/git-gui/version
 	@rm -rf $(GIT_TARNAME)
Jakub Narebski· Jun 19, 2007, 00:39 UTC · re: Matthias Lederhofer · lore

Re: [PATCH] make dist: include configure script in tarball

Matthias Lederhofer wrote:
> +dist: git.spec git-archive configure
Ack. This way you don't need autoconf to ./configure install.
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Johannes Schindelin· Jun 19, 2007, 01:03 UTC · re: Jakub Narebski · lore

Re: [PATCH] make dist: include configure script in tarball

Hi,
On Tue, 19 Jun 2007, Jakub Narebski wrote:
Show 5 quoted lines
> Matthias Lederhofer wrote:
> 
> > +dist: git.spec git-archive configure
> 
> Ack. This way you don't need autoconf to ./configure install.
... but you force our good maintainer to have it installed...

Ciao, Dscho

Junio C Hamano· Jun 19, 2007, 02:36 UTC · re: Johannes Schindelin · lore

Re: [PATCH] make dist: include configure script in tarball

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 9 quoted lines
> On Tue, 19 Jun 2007, Jakub Narebski wrote:
>
>> Matthias Lederhofer wrote:
>> 
>> > +dist: git.spec git-archive configure
>> 
>> Ack. This way you don't need autoconf to ./configure install.
>
> ... but you force our good maintainer to have it installed...

Which is fine by me. I was wondering why this wish did not surface much earlier myself.

Not that I'd use "./configure" myself nor help debugging the autoconf-generated shell scripts ;-).

Johannes Schindelin· Jun 19, 2007, 09:34 UTC · re: Junio C Hamano · lore

Re: [PATCH] make dist: include configure script in tarball

Hi,
On Mon, 18 Jun 2007, Junio C Hamano wrote:
Show 13 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Tue, 19 Jun 2007, Jakub Narebski wrote:
> >
> >> Matthias Lederhofer wrote:
> >> 
> >> > +dist: git.spec git-archive configure
> >> 
> >> Ack. This way you don't need autoconf to ./configure install.
> >
> > ... but you force our good maintainer to have it installed...
> 
> Which is fine by me.
Good. That was the kind of Ack I was waiting for.
> I was wondering why this wish did not surface much earlier myself.

When I was trying to be lazy, and ran configure myself on some machine (sorry, don't remember which one, might well be a MinGW setup), it did not work. So I did not push for it.

> Not that I'd use "./configure" myself nor help debugging the 
> autoconf-generated shell scripts ;-).
I fully understand.

Ciao, Dscho

← back to recent threads