threads / patch / 8589

patchAdd a guilt-export(1) command to export a guilt series to quilt.

Subject: [PATCH] Add a guilt-export(1) command to export a guilt series to quilt.

## tl;dr

6 messages between Jun 13, 2007 and Jun 14, 2007. Diffs are folded; open one to read it.

replies: 5people: 3as markdown or json

Pierre Habouzit· Jun 13, 2007, 14:01 UTC · lore
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---
 Documentation/guilt-export.txt |   30 ++++++++++++++++++++++++++++++
 guilt-export                   |   26 ++++++++++++++++++++++++++
 2 files changed, 56 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/guilt-export.txt
 create mode 100755 guilt-export
Show changes to 2 files +56 −0

Documentation/guilt-export.txt, guilt-export

diff --git a/Documentation/guilt-export.txt b/Documentation/guilt-export.txt
new file mode 100644
index 0000000..b7b0a4b
--- /dev/null
+++ b/Documentation/guilt-export.txt
@@ -0,0 +1,30 @@
+guilt-export(1)
+===============
+
+NAME
+----
+guilt-export - Export a patch series (to be used by quilt)
+
+SYNOPSIS
+--------
+include::usage-guilt-export.txt[]
+
+DESCRIPTION
+-----------
+Export a guilt series to be used by quilt.
+
+OPTIONS
+-------
+<target_dir>::
+        Name of the directory to export the patch series to.
+        (defaults to patches).
+
+Author
+------
+Written by Pierre Habouzit <madcoder@debian.org>
+
+Documentation
+-------------
+Documentation by Pierre Habouzit <madcoder@debian.org>
+
+include::footer.txt[]
diff --git a/guilt-export b/guilt-export
new file mode 100755
index 0000000..9ff9924
--- /dev/null
+++ b/guilt-export
@@ -0,0 +1,26 @@
+#!/bin/bash
+#
+# Copyright (c) Pierre Habouzit, 2007
+#
+
+USAGE="[<target_dir>]"
+. guilt
+
+if [ $# -gt 1 ]; then
+	usage
+fi
+target_dir=${1:-"patches"}
+
+if [ -e "$target_dir" ]; then
+	die "Specified directory already exists"
+fi
+
+trap "rm -rf \"$target_dir\"" 0
+mkdir -p "$target_dir"
+
+get_series | tee "$target_dir/series" | while read p; do
+	cp "$GUILT_DIR/$branch/$p" "$target_dir/$p"
+done
+
+trap - 0
+echo "Series exported to \"$target_dir\" sucessfully."

-- 
1.5.2.1
Benjamin Sergeant· Jun 13, 2007, 15:10 UTC · re: Pierre Habouzit · lore

Re: [PATCH] Add a guilt-export(1) command to export a guilt series to quilt.

For the shebang: #!/usr/bin/env bash should works well and should work on non-linux boxes that did not added a link in /bin/bash.

My 2 cents.
On 6/13/07, Pierre Habouzit <madcoder@debian.org> wrote:
Show 84 quoted lines
> Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> ---
>  Documentation/guilt-export.txt |   30 ++++++++++++++++++++++++++++++
>  guilt-export                   |   26 ++++++++++++++++++++++++++
>  2 files changed, 56 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/guilt-export.txt
>  create mode 100755 guilt-export
>
> diff --git a/Documentation/guilt-export.txt b/Documentation/guilt-export.txt
> new file mode 100644
> index 0000000..b7b0a4b
> --- /dev/null
> +++ b/Documentation/guilt-export.txt
> @@ -0,0 +1,30 @@
> +guilt-export(1)
> +===============
> +
> +NAME
> +----
> +guilt-export - Export a patch series (to be used by quilt)
> +
> +SYNOPSIS
> +--------
> +include::usage-guilt-export.txt[]
> +
> +DESCRIPTION
> +-----------
> +Export a guilt series to be used by quilt.
> +
> +OPTIONS
> +-------
> +<target_dir>::
> +        Name of the directory to export the patch series to.
> +        (defaults to patches).
> +
> +Author
> +------
> +Written by Pierre Habouzit <madcoder@debian.org>
> +
> +Documentation
> +-------------
> +Documentation by Pierre Habouzit <madcoder@debian.org>
> +
> +include::footer.txt[]
> diff --git a/guilt-export b/guilt-export
> new file mode 100755
> index 0000000..9ff9924
> --- /dev/null
> +++ b/guilt-export
> @@ -0,0 +1,26 @@
> +#!/bin/bash
> +#
> +# Copyright (c) Pierre Habouzit, 2007
> +#
> +
> +USAGE="[<target_dir>]"
> +. guilt
> +
> +if [ $# -gt 1 ]; then
> +       usage
> +fi
> +target_dir=${1:-"patches"}
> +
> +if [ -e "$target_dir" ]; then
> +       die "Specified directory already exists"
> +fi
> +
> +trap "rm -rf \"$target_dir\"" 0
> +mkdir -p "$target_dir"
> +
> +get_series | tee "$target_dir/series" | while read p; do
> +       cp "$GUILT_DIR/$branch/$p" "$target_dir/$p"
> +done
> +
> +trap - 0
> +echo "Series exported to \"$target_dir\" sucessfully."
> --
> 1.5.2.1
>
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Pierre Habouzit· Jun 13, 2007, 15:16 UTC · re: Benjamin Sergeant · lore

Re: [PATCH] Add a guilt-export(1) command to export a guilt series to quilt.

On Wed, Jun 13, 2007 at 08:10:36AM -0700, Benjamin Sergeant wrote:
> For the shebang:
> #!/usr/bin/env bash
> should works well and should work on non-linux boxes that did not
> added a link in /bin/bash.
  FWIW it would spawn a process for nothin, and every other guilt
command uses that. People using it on non linux box would have to run a
sed on every shebang at install time, that's not _that_ hard anyways,
and is common practice with python or perl scripts e.g. IMHO it's not a
problem.
-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org
Josef Sipek· Jun 13, 2007, 15:54 UTC · re: Benjamin Sergeant · lore

Re: [PATCH] Add a guilt-export(1) command to export a guilt series to quilt.

On Wed, Jun 13, 2007 at 08:10:36AM -0700, Benjamin Sergeant wrote:
> For the shebang:
> #!/usr/bin/env bash
> should works well and should work on non-linux boxes that did not
> added a link in /bin/bash.
 
Ideally, the best thing to do is to change guilt to use /bin/sh. Right now,
there are a number of bash-isms that are used. And if a system doesn't have
/bin/sh, it doesn't deserve to run any useful software ;)
Patches are welcomed ;)
Josef "Jeff" Sipek.
-- 
Reality is merely an illusion, albeit a very persistent one.
		- Albert Einstein
Pierre Habouzit· Jun 14, 2007, 10:38 UTC · re: Josef Sipek · lore

Re: [PATCH] Add a guilt-export(1) command to export a guilt series to quilt.

On Wed, Jun 13, 2007 at 11:54:54AM -0400, Josef Sipek wrote:
Show 11 quoted lines
> On Wed, Jun 13, 2007 at 08:10:36AM -0700, Benjamin Sergeant wrote:
> > For the shebang:
> > #!/usr/bin/env bash
> > should works well and should work on non-linux boxes that did not
> > added a link in /bin/bash.
>  
> Ideally, the best thing to do is to change guilt to use /bin/sh. Right now,
> there are a number of bash-isms that are used. And if a system doesn't have
> /bin/sh, it doesn't deserve to run any useful software ;)
> 
> Patches are welcomed ;)
  Makes sense. I'm currently working on it (so that nobody loses time on
that issue).
  I'm mostly done with guilt(1), I still need to take some "local"
variables down (especially in guilt_push or whatever the function name
is). Most of the rest has been dealt with already.
  I should send a patch serie towards POSIX-shell-isation soon, as soon
as I've tested the patches with bash, zsh, dash and posh.
  Cheers,
-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org
Josef Sipek· Jun 13, 2007, 15:51 UTC · re: Pierre Habouzit · lore

Re: [PATCH] Add a guilt-export(1) command to export a guilt series to quilt.

On Wed, Jun 13, 2007 at 04:01:53PM +0200, Pierre Habouzit wrote:
Show 7 quoted lines
> Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> ---
>  Documentation/guilt-export.txt |   30 ++++++++++++++++++++++++++++++
>  guilt-export                   |   26 ++++++++++++++++++++++++++
>  2 files changed, 56 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/guilt-export.txt
>  create mode 100755 guilt-export
Applied.
Thanks.
Josef "Jeff" Sipek.
-- 
Computer Science is no more about computers than astronomy is about
telescopes.
		- Edsger Dijkstra

← back to recent threads