# [PATCH] Don't dereference a strdup-returned NULL

1 messages from 2007-06-12 to 2007-06-12. Participants: Jim Meyering.
Thread: https://gitlist.dev/t/8577

## Jim Meyering, 2007-06-12 20:59

Subject: [PATCH] Don't dereference a strdup-returned NULL
Message-ID: <87abv4ubx2.fsf@rho.meyering.net>
URL: https://gitlist.dev/e/87abv4ubx2.fsf%40rho.meyering.net

```
There are only a dozen or so uses of strdup in all of git.
Of those, most seem ok, but this one isn't:

Signed-off-by: Jim Meyering <jim@meyering.net>
---
 remote.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/remote.c b/remote.c
index 33c8e50..ed62a62 100644
--- a/remote.c
+++ b/remote.c
@@ -542,7 +542,7 @@ int match_refs(struct ref *src, struct ref *dst, struct ref ***dst_tail,
 			strcpy(dst_name, pat->dst);
 			strcat(dst_name, src->name + strlen(pat->src));
 		} else
-			dst_name = strdup(src->name);
+			dst_name = xstrdup(src->name);
 		dst_peer = find_ref_by_name(dst, dst_name);
 		if (dst_peer && dst_peer->peer_ref)
 			/* We're already sending something to this ref. */
--
1.5.2.1.159.g8d11

```