# [RFC][PATCH 10/10] Sparse: fix a "symbol 'weak_match' shadows an earlier one" warning 3 messages from 2007-06-08 to 2007-06-12. Participants: Ramsay Jones, Junio C Hamano. Thread: https://gitlist.dev/t/8522 ## Ramsay Jones, 2007-06-08 22:27 Subject: [RFC][PATCH 10/10] Sparse: fix a "symbol 'weak_match' shadows an earlier one" warning Message-ID: <4669D7BC.3060607@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4669D7BC.3060607%40ramsay1.demon.co.uk ``` Signed-off-by: Ramsay Jones --- connect.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/connect.c b/connect.c index da89c9c..d4051dd 100644 --- a/connect.c +++ b/connect.c @@ -179,7 +179,6 @@ static int count_refspec_match(const char *pattern, for (weak_match = match = 0; refs; refs = refs->next) { char *name = refs->name; int namelen = strlen(name); - int weak_match; if (namelen < patlen || memcmp(name + namelen - patlen, pattern, patlen)) -- 1.5.2 ``` ## Junio C Hamano, 2007-06-09 08:07 Subject: Re: [RFC][PATCH 10/10] Sparse: fix a "symbol 'weak_match' shadows an earlier one" warning Message-ID: <7vr6olh7pb.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vr6olh7pb.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <4669D7BC.3060607@ramsay1.demon.co.uk> ``` Ramsay Jones writes: > Signed-off-by: Ramsay Jones > --- > connect.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/connect.c b/connect.c > index da89c9c..d4051dd 100644 > --- a/connect.c > +++ b/connect.c > @@ -179,7 +179,6 @@ static int count_refspec_match(const char *pattern, > for (weak_match = match = 0; refs; refs = refs->next) { > char *name = refs->name; > int namelen = strlen(name); > - int weak_match; > > if (namelen < patlen || > memcmp(name + namelen - patlen, pattern, patlen)) This one is an obvious bug. Essentially, it makes weak matches ignored. Unfortunately this has been hiding a larger bug in the caller of this function. I am refactoring the mess right now. ``` ## Ramsay Jones, 2007-06-12 17:43 Subject: Re: [RFC][PATCH 10/10] Sparse: fix a "symbol 'weak_match' shadows an earlier one" warning Message-ID: <466EDB3D.4070302@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/466EDB3D.4070302%40ramsay1.demon.co.uk In-Reply-To: <7vr6olh7pb.fsf@assigned-by-dhcp.cox.net> ``` Junio C Hamano wrote: > Ramsay Jones writes: > >> Signed-off-by: Ramsay Jones >> --- >> connect.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/connect.c b/connect.c >> index da89c9c..d4051dd 100644 >> --- a/connect.c >> +++ b/connect.c >> @@ -179,7 +179,6 @@ static int count_refspec_match(const char *pattern, >> for (weak_match = match = 0; refs; refs = refs->next) { >> char *name = refs->name; >> int namelen = strlen(name); >> - int weak_match; >> >> if (namelen < patlen || >> memcmp(name + namelen - patlen, pattern, patlen)) > > This one is an obvious bug. Indeed ;-) Also, I'm guessing it does not bring your machine down like a house of cards. ... Essentially, it makes weak matches > ignored. Unfortunately this has been hiding a larger bug in the > caller of this function. I am refactoring the mess right now. > Great. Hopefully it will also address the cygwin issue. ATB Ramsay Jones ```