[PATCH] New selection indication and softer colors

Matthijs Melchior· Jun 5, 2007, 21:50 UTC · lore

The default font was already bold, so marking the selected file with bold font did not work. Change that to lightgray background. Also, the header colors are now softer, giving better readability.

Signed-off-by: Matthijs Melchior <mmelchior@xs4all.nl>
---

This gives better colors on my Debian Gnome desktop.

I hope you like it too.

 git-gui.sh |   18 ++++++++----------
 1 files changed, 8 insertions(+), 10 deletions(-)

Show changes to git-gui.sh +8 −10

diff --git a/git-gui.sh b/git-gui.sh
index d4ad73c..e33ee03 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -1764,7 +1764,7 @@ pack .vpane -anchor n -side top -fill both -expand 1
 #
 frame .vpane.files.index -height 100 -width 200
 label .vpane.files.index.title -text {Staged Changes (Will Be Committed)} \
-	-background green
+	-background lightgreen
 text $ui_index -background white -borderwidth 0 \
 	-width 20 -height 10 \
 	-wrap none \
@@ -1784,7 +1784,7 @@ pack $ui_index -side left -fill both -expand 1
 #
 frame .vpane.files.workdir -height 100 -width 200
 label .vpane.files.workdir.title -text {Unstaged Changes (Will Not Be Committed)} \
-	-background red
+	-background lightsalmon
 text $ui_workdir -background white -borderwidth 0 \
 	-width 20 -height 10 \
 	-wrap none \
@@ -1801,10 +1801,8 @@ pack $ui_workdir -side left -fill both -expand 1
 .vpane.files add .vpane.files.workdir -sticky nsew
 
 foreach i [list $ui_index $ui_workdir] {
-	$i tag conf in_diff -font font_uibold
-	$i tag conf in_sel \
-		-background [$i cget -foreground] \
-		-foreground [$i cget -background]
+	$i tag conf in_diff -background lightgray
+	$i tag conf in_sel  -background lightgray
 }
 unset i
 
@@ -1962,18 +1960,18 @@ proc trace_current_diff_path {varname args} {
 }
 trace add variable current_diff_path write trace_current_diff_path
 
-frame .vpane.lower.diff.header -background orange
+frame .vpane.lower.diff.header -background gold
 label .vpane.lower.diff.header.status \
-	-background orange \
+	-background gold \
 	-width $max_status_desc \
 	-anchor w \
 	-justify left
 label .vpane.lower.diff.header.file \
-	-background orange \
+	-background gold \
 	-anchor w \
 	-justify left
 label .vpane.lower.diff.header.path \
-	-background orange \
+	-background gold \
 	-anchor w \
 	-justify left
 pack .vpane.lower.diff.header.status -side left

-- 
1.5.2.1

Shawn O. Pearce· Jun 6, 2007, 05:24 UTC · re: Matthijs Melchior · lore

Re: [PATCH] New selection indication and softer colors

Matthijs Melchior <mmelchior@xs4all.nl> wrote:

> The default font was already bold, so marking the selected file with bold
> font did not work.  Change that to lightgray background.
> Also, the header colors are now softer, giving better readability.

Thanks, this is actually kind of nice. I've applied it to my maint and pushed it out. I feel a gitgui-0.7.3 coming real soon (maint has 8 new commits on it already).

-- 
Shawn.

patchNew selection indication and softer colors