threads / patch / 8447

patch$EMAIL is a last resort fallback, as it's system-wide.

Subject: [PATCH] $EMAIL is a last resort fallback, as it's system-wide.

## tl;dr

One message between Jun 5, 2007 and Jun 5, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Pierre Habouzit· Jun 5, 2007, 16:40 UTC · lore
  Rationale: $EMAIL is a system-wide setup that is used for many many many
applications. If the git user chose a specific user.email setup, then _this_
should be honoured rather than $EMAIL.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---
 ident.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Show changes to ident.c +2 −2
diff --git a/ident.c b/ident.c
index 69a04b8..3d49608 100644
--- a/ident.c
+++ b/ident.c
@@ -196,9 +196,9 @@ const char *fmt_ident(const char *name, const char *email,
 	if (!name)
 		name = git_default_name;
 	if (!email)
-		email = getenv("EMAIL");
-	if (!email)
 		email = git_default_email;
+	if (!email)
+		email = getenv("EMAIL");
 
 	if (!*name) {
 		struct passwd *pw;
-- 
1.5.2.1

← back to recent threads