# [tig PATCH] Fix integer type mismatch on 64-bit systems

2 messages from 2007-06-03 to 2007-06-04. Participants: Steven Grimm, Jonas Fonseca.
Thread: https://gitlist.dev/t/8416

## Steven Grimm, 2007-06-03 21:12

Subject: [tig PATCH] Fix integer type mismatch on 64-bit systems
Message-ID: <20070603211206.GA16445@midwinter.com>
URL: https://gitlist.dev/e/20070603211206.GA16445%40midwinter.com

```
fprintf wants an int parameter for the field width of a "%.*s" expression, but
the code was passing a size_t instead. This potentially broke systems where
sizeof(size_t) != sizeof(int). And even on systems where it did't break,
it still caused a compiler warning.
---
 tig.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tig.c b/tig.c
index 6adfb33..b09d91b 100644
--- a/tig.c
+++ b/tig.c
@@ -1153,7 +1153,7 @@ read_option(char *opt, size_t optlen, char *value, size_t valuelen)
 
 	if (status == ERR) {
 		fprintf(stderr, "Error on line %d, near '%.*s': %s\n",
-			config_lineno, optlen, opt, config_msg);
+			config_lineno, (int) optlen, opt, config_msg);
 		config_errors = TRUE;
 	}
 
-- 
1.5.2.35.ga334

```

## Jonas Fonseca, 2007-06-04 06:47

Subject: Re: [tig PATCH] Fix integer type mismatch on 64-bit systems
Message-ID: <2c6b72b30706032347m6a67fcf7h6b56c1d1078c1ffd@mail.gmail.com>
URL: https://gitlist.dev/e/2c6b72b30706032347m6a67fcf7h6b56c1d1078c1ffd%40mail.gmail.com
In-Reply-To: <20070603211206.GA16445@midwinter.com>

```
On 6/3/07, Steven Grimm <koreth@midwinter.com> wrote:
> fprintf wants an int parameter for the field width of a "%.*s" expression, but
> the code was passing a size_t instead. This potentially broke systems where
> sizeof(size_t) != sizeof(int). And even on systems where it did't break,
> it still caused a compiler warning.

Thanks, I also fixed another such occurrence.

BTW, in good git spirit you are encouraged to sign off your patches. :)

-- 
Jonas Fonseca

```