threads / patch / 8335

patch, 3 partsRe: [PATCH 1/3] Lazily open pack index files on demand

Subject: Re: [PATCH 1/3] Lazily open pack index files on demand

## tl;dr

2 messages between May 27, 2007 and May 27, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Martin Koegler· May 27, 2007, 10:46 UTC · lore

Dana How wrote:

> (1c) Do not deltify naughty blobs.  Naughty blobs are those
>      blobs marked "nodelta" or very large blobs.

I don't like the idea to exclude any blobs from delta by default, if the delta could be done. If the "very large blobs" are text files with very few difference, they deltifiy very well.

Additionlly, how do you want to define "very large blobs"?

For a system with eg. 256MB of RAM, deltifiny a blob with some hundred MBs is a problem whereas it is no problem, if you have some GB of RAM.

mfg Martin Kögler

Nicolas Pitre· May 27, 2007, 15:36 UTC · re: Martin Koegler · lore

On Sun, 27 May 2007, Martin Koegler wrote:

Show 6 quoted lines

> Dana How wrote:
> > (1c) Do not deltify naughty blobs.  Naughty blobs are those
> >      blobs marked "nodelta" or very large blobs.
> 
> I don't like the idea to exclude any blobs from delta by default, if
> the delta could be done.

It won't happen by default.

> If the "very large blobs" are text files with
> very few difference, they deltifiy very well.
> 
> Additionlly, how do you want to define "very large blobs"?

This is indeed a per repository attribute that is highly dependent on your data set.

Nicolas