threads / patch / 8264

patchgit-daemon: don't ignore pid-file write failure

Subject: [PATCH] git-daemon: don't ignore pid-file write failure

## tl;dr

One message between May 21, 2007 and May 21, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Jim Meyering· May 21, 2007, 07:58 UTC · lore
Note: since the consequence of failure is to call die,
I don't bother to close "f".
Signed-off-by: Jim Meyering <jim@meyering.net>
---
 daemon.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Show changes to daemon.c +2 −3
diff --git a/daemon.c b/daemon.c
index e74ecac..674e30d 100644
--- a/daemon.c
+++ b/daemon.c
@@ -970,8 +970,8 @@ static void store_pid(const char *path)
 	FILE *f = fopen(path, "w");
 	if (!f)
 		die("cannot open pid file %s: %s", path, strerror(errno));
-	fprintf(f, "%d\n", getpid());
-	fclose(f);
+	if (fprintf(f, "%d\n", getpid()) < 0 || fclose(f) != 0)
+		die("failed to write pid file %s: %s", path, strerror(errno));
 }

 static int serve(char *listen_addr, int listen_port, struct passwd *pass, gid_t gid)
--
1.5.2

← back to recent threads