# [PATCH] Git.pm: Add remote_refs() git-ls-remote frontend 3 messages from 2007-05-17 to 2007-05-17. Participants: Petr Baudis, Junio C Hamano. Thread: https://gitlist.dev/t/8188 ## Petr Baudis, 2007-05-17 02:37 Subject: [PATCH] Git.pm: Add remote_refs() git-ls-remote frontend Message-ID: <20070517023743.1982.41240.stgit@rover> URL: https://gitlist.dev/e/20070517023743.1982.41240.stgit%40rover ``` Should support all the important features, I guess. Too bad that git-ls-remote --heads . is subtly different from git-ls-remote . refs/heads/ so we have to provide the interface for specifying both. This patch also converts git-svn.perl to use it. Signed-off-by: Petr Baudis --- git-remote.perl | 5 +---- perl/Git.pm | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 55 insertions(+), 5 deletions(-) diff --git a/git-remote.perl b/git-remote.perl index 5763799..5403d86 100755 --- a/git-remote.perl +++ b/git-remote.perl @@ -128,10 +128,7 @@ sub update_ls_remote { return if (($harder == 0) || (($harder == 1) && exists $info->{'LS_REMOTE'})); - my @ref = map { - s|^[0-9a-f]{40}\s+refs/heads/||; - $_; - } $git->command(qw(ls-remote --heads), $info->{'URL'}); + my @ref = keys %{$git->remote_refs($info->{'URL'}, [ 'heads' ])}; $info->{'LS_REMOTE'} = \@ref; } diff --git a/perl/Git.pm b/perl/Git.pm index 8fd3611..9818981 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -51,7 +51,7 @@ require Exporter; # Methods which can be called as standalone functions as well: @EXPORT_OK = qw(command command_oneline command_noisy command_output_pipe command_input_pipe command_close_pipe - version exec_path hash_object git_cmd_try); + version exec_path hash_object git_cmd_try remote_refs); =head1 DESCRIPTION @@ -550,6 +550,59 @@ sub config_bool { } +=item remote_refs ( REPOSITORY [, GROUPS [, REFGLOBS ] ] ) + +This function returns a hashref of refs stored in a given remote repository. +The hash is in the format C hash>. For tags, the C entry +contains the tag object while a C entry gives the tagged objects. + +C has the same meaning as the appropriate C +argument; either an URL or a remote name (if called on a repository instance). +C is an optional arrayref that can contain 'tags' to return all the +tags and/or 'heads' to return all the heads. C is an optional array +of strings containing a shell-like glob to further limit the refs returned in +the hash; the meaning is again the same as the appropriate C +argument. + +This function may or may not be called on a repository instance. In the former +case, remote names as defined in the repository are recognized as repository +specifiers. + +=cut + +sub remote_refs { + my ($self, $repo, $groups, $refglobs) = _maybe_self(@_); + my @args; + if (ref $groups eq 'ARRAY') { + foreach (@$groups) { + if ($_ eq 'heads') { + push (@args, '--heads'); + } elsif ($_ eq 'tags') { + push (@args, '--tags'); + } else { + # Ignore unknown groups for future + # compatibility + } + } + } + push (@args, $repo); + if (ref $refglobs eq 'ARRAY') { + push (@args, @$refglobs); + } + + my @self = $self ? ($self) : (); # Ultra trickery + my ($fh, $ctx) = Git::command_output_pipe(@self, 'ls-remote', @args); + my %refs; + while (<$fh>) { + chomp; + my ($hash, $ref) = split(/\t/, $_, 2); + $refs{$ref} = $hash; + } + Git::command_close_pipe(@self, $fh, $ctx); + return \%refs; +} + + =item ident ( TYPE | IDENTSTR ) =item ident_person ( TYPE | IDENTSTR | IDENTARRAY ) ``` ## Junio C Hamano, 2007-05-17 05:58 Subject: Re: [PATCH] Git.pm: Add remote_refs() git-ls-remote frontend Message-ID: <7vk5v89ek8.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vk5v89ek8.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20070517023743.1982.41240.stgit@rover> ``` Petr Baudis writes: > .... Too bad that > > git-ls-remote --heads . > > is subtly different from > > git-ls-remote . refs/heads/ > > so we have to provide the interface for specifying both. I've already heard you say the above elsewhere, but I am not sure what you exactly mean here. Mind substantiating it a bit more clearly? I think "ls-remote --heads ." is just a special case of giving "refs/heads/*" as the glob pattern: $ git ls-remote --heads . | head -n 3 3545193735522f733fdb4e345f16ddf131e2007a refs/heads/ap/ident b7993dd57a9cfd5b989f0e2cc5d271a524339318 refs/heads/db/remote 960ccca6803c9fb57429d43572a9545a96107e32 refs/heads/dh/pack $ git ls-remote . refs/heads/ | wc -l 0 $ git ls-remote . "refs/heads/*" | head -n 3 3545193735522f733fdb4e345f16ddf131e2007a refs/heads/ap/ident b7993dd57a9cfd5b989f0e2cc5d271a524339318 refs/heads/db/remote 960ccca6803c9fb57429d43572a9545a96107e32 refs/heads/dh/pack $ git ls-remote . "refs/heads/???/*" 7841ce79854868eaaa146c1d018b17fc4f3320be refs/heads/mst/connect $ git ls-remote . "refs/*/jc/*" | head -n 4 80a767ba3b1c69fc41fa5f5fbe4a247757a9c575 refs/heads/jc/blame a1481ab7b16c51d4ec7925fd9b38d9cf21f72263 refs/heads/jc/diff 4e8daa0dca5deb9d391538241939a2a2ad6d36b8 refs/tags/hold/jc/3way ff77ab7919e6f31cb6c58bc004217e624b553fb6 refs/tags/hold/jc/changes So if you really do not want separate interfaces, I think you could just implement --heads as what it is: a shorthand for "refs/heads/*". ``` ## Petr Baudis, 2007-05-17 11:30 Subject: Re: [PATCH] Git.pm: Add remote_refs() git-ls-remote frontend Message-ID: <20070517113028.GN4489@pasky.or.cz> URL: https://gitlist.dev/e/20070517113028.GN4489%40pasky.or.cz In-Reply-To: <7vk5v89ek8.fsf@assigned-by-dhcp.cox.net> ``` On Thu, May 17, 2007 at 07:58:31AM CEST, Junio C Hamano wrote: > Petr Baudis writes: > > > .... Too bad that > > > > git-ls-remote --heads . > > > > is subtly different from > > > > git-ls-remote . refs/heads/ > > > > so we have to provide the interface for specifying both. > > I've already heard you say the above elsewhere, but I am not > sure what you exactly mean here. Mind substantiating it a bit > more clearly? Because the arguments are matched like case "/$path" in */$pat ) so if you have remote "refs" and refs/remote/refs/heads/x, git-ls-remote refs/heads/ is ambiguous. OTOH, --heads always match start of the path. It's somewhat obscure and probably doesn't really matter for user interface, but API should be free even of obscure misbehaviour, I believe. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ Ever try. Ever fail. No matter. // Try again. Fail again. Fail better. -- Samuel Beckett ```