threads / discuss / 8095

Subproject clones

Subject: Subproject clones

## tl;dr

4 messages between May 12, 2007 and May 12, 2007.

replies: 3people: 3as markdown or json

Amos Waterland· May 12, 2007, 01:16 UTC · lore

The logic in t3040-subprojects-basic.sh assumes that comparing the output of 'git-ls-files -s' when run in the original superproject and when run in the cloned superproject is a good test that cloning worked.

However, the output of git-ls-files does not include the files in subprojects, so this test passes, even though the clone contains only the directories of the subprojects and none of their containing files or .git subdirectories.

In other words, given this:
 superproject
  sub1
   Makefile
  sub2
   Makefile

when somebody does `git-clone superproject', I believe they expect to get the same tree. Instead, they get this:

 superproject
  sub1
  sub2

Note that `git-clone superproject/sub1` works as expected, but this sequence fails:

 git-clone superproject foo 
 cd foo
 git-clone ../superproject/sub1
As does this sequence:
 git-clone superproject foo 
 cd foo/sub1
 git-pull ../superproject/sub1

So there is no way that I can see to actually clone a project that has subprojects.

Is this intentional?  Shouldn't clone get the entire superproject?
Junio C Hamano· May 12, 2007, 01:26 UTC · re: Amos Waterland · lore

Re: Subproject clones

apw@us.ibm.com (Amos Waterland) writes:
> Is this intentional?  Shouldn't clone get the entire superproject?

Yes. As 1.5.2 draft release notes and my response to somebody else last night mentioned, the plumbing level subproject support does _NOT_ recurse into subproject and this is deliberate.

Junio C Hamano· May 12, 2007, 01:32 UTC · re: Junio C Hamano · lore

Re: Subproject clones

Junio C Hamano <junkio@cox.net> writes:
Show 7 quoted lines
> apw@us.ibm.com (Amos Waterland) writes:
>
>> Is this intentional?  Shouldn't clone get the entire superproject?
>
> Yes.  As 1.5.2 draft release notes and my response to somebody
> else last night mentioned, the plumbing level subproject support
> does _NOT_ recurse into subproject and this is deliberate.
Namely:
    http://article.gmane.org/gmane.comp.version-control.git/46934
    http://article.gmane.org/gmane.comp.version-control.git/46940
Sven Verdoolaege· May 12, 2007, 08:05 UTC · re: Amos Waterland · lore

Re: Subproject clones

On Fri, May 11, 2007 at 09:16:00PM -0400, Amos Waterland wrote:
Show 10 quoted lines
> In other words, given this:
> 
>  superproject
>   sub1
>    Makefile
>   sub2
>    Makefile
> 
> when somebody does `git-clone superproject', I believe they expect to
> get the same tree.  Instead, they get this:

I'm working on something like that. See the thread at

	http://article.gmane.org/gmane.comp.version-control.git/46163
I hope to send out an updated version later this weekend.
skimo

← back to recent threads