# [PATCH] gitweb: choose appropriate view for file type if a= parameter missing. 5 messages from 2007-05-09 to 2007-05-13. Participants: Gerrit Pape, Junio C Hamano, Jakub Narebski. Thread: https://gitlist.dev/t/8060 ## Gerrit Pape, 2007-05-09 22:19 Subject: [PATCH] gitweb: choose appropriate view for file type if a= parameter missing. Message-ID: <20070509221928.17244.qmail@f9729cdcdf57d1.315fe32.mid.smarden.org> URL: https://gitlist.dev/e/20070509221928.17244.qmail%40f9729cdcdf57d1.315fe32.mid.smarden.org ``` See http://bugs.debian.org/410465 gitweb URLs use the a= parameter for the view to use on the given path, such as "blob" or "tree". Currently, if a gitweb URL omits the a= parameter, gitweb just shows the top-level repository summary, regardless of the path given. gitweb could instead choose an appropriate view based on the file type: blob for blobs (files), tree for trees (directories), and summary if no path given (the URL included no f= parameter, or an empty f= parameter). Apart from making gitweb more robust and supporting URL editing more easily, this change would aid the creation of shortcuts to git repositories using simple substitution, such as: http://example.org/git/?p=path/to/repo.git;hb=HEAD;f=%s - Josh Triplett Signed-off-by: Gerrit Pape --- gitweb/gitweb.perl | 14 ++++++++++---- 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 90243fd..21864c6 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -458,10 +458,16 @@ my %actions = ( "project_index" => \&git_project_index, ); -if (defined $project) { - $action ||= 'summary'; -} else { - $action ||= 'project_list'; +if (!defined $action) { + if (defined $hash) { + $action = git_get_type($hash); + } elsif (defined $hash_base && defined $file_name) { + $action = git_get_type("$hash_base:$file_name"); + } elsif (defined $project) { + $action = 'summary'; + } else { + $action = 'project_list'; + } } if (!defined($actions{$action})) { die_error(undef, "Unknown action"); -- 1.5.1.3 ``` ## Junio C Hamano, 2007-05-10 02:04 Subject: Re: [PATCH] gitweb: choose appropriate view for file type if a= parameter missing. Message-ID: <7vvef1o2ni.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vvef1o2ni.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20070509221928.17244.qmail@f9729cdcdf57d1.315fe32.mid.smarden.org> ``` Gerrit Pape writes: > See http://bugs.debian.org/410465 > > gitweb URLs use the a= parameter for the view to use on the given path, such > as "blob" or "tree". Currently, if a gitweb URL omits the a= parameter, > gitweb just shows the top-level repository summary, regardless of the path > given. gitweb could instead choose an appropriate view based on the file > type: blob for blobs (files), tree for trees (directories), and summary if no > path given (the URL included no f= parameter, or an empty f= parameter). > > Apart from making gitweb more robust and supporting URL editing more easily, > this change would aid the creation of shortcuts to git repositories using > simple substitution, such as: > http://example.org/git/?p=path/to/repo.git;hb=HEAD;f=%s > > - Josh Triplett > > Signed-off-by: Gerrit Pape I am not sure if this is a "good" feature or just "because we can" feature, but I am slightly in favor. I do not know about others. I'd however request a few changes to the proposed commit log message: * "See http://..." is not the primary information, but "see ... for further details"; please have it at the end, not at the beginning. * Was the patch authored by you, or Josh? If the former, what's his name doing here? Perhaps you wanted to say "Reported by Josh Triplett"? ``` ## Gerrit Pape, 2007-05-10 07:32 Subject: [PATCH] gitweb: choose appropriate view for file type if a= parameter missing Message-ID: <20070510073207.21562.qmail@25d0c789693af2.315fe32.mid.smarden.org> URL: https://gitlist.dev/e/20070510073207.21562.qmail%4025d0c789693af2.315fe32.mid.smarden.org In-Reply-To: <7vvef1o2ni.fsf@assigned-by-dhcp.cox.net> ``` gitweb URLs use the a= parameter for the view to use on the given path, such as "blob" or "tree". Currently, if a gitweb URL omits the a= parameter, gitweb just shows the top-level repository summary, regardless of the path given. gitweb could instead choose an appropriate view based on the file type: blob for blobs (files), tree for trees (directories), and summary if no path given (the URL included no f= parameter, or an empty f= parameter). Apart from making gitweb more robust and supporting URL editing more easily, this change would aid the creation of shortcuts to git repositories using simple substitution, such as: http://example.org/git/?p=path/to/repo.git;hb=HEAD;f=%s With this patch, if given the hash through the h= parameter, or the hash base (hb=) and a filename (f=), gitweb uses cat-file -t to automatically set the a= parameter. This feature was requested by Josh Triplett through http://bugs.debian.org/410465 Signed-off-by: Gerrit Pape --- On Wed, May 09, 2007 at 07:04:01PM -0700, Junio C Hamano wrote: > I'd however request a few changes to the proposed commit log > message: > > * "See http://..." is not the primary information, but "see > ... for further details"; please have it at the end, not at > the beginning. Okay. > * Was the patch authored by you, or Josh? If the former, > what's his name doing here? Perhaps you wanted to say > "Reported by Josh Triplett"? Sometimes I'm lazy, it was just a copy&paste from the Debian bug report submitted by Josh. Regards, Gerrit. gitweb/gitweb.perl | 14 ++++++++++---- 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 90243fd..21864c6 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -458,10 +458,16 @@ my %actions = ( "project_index" => \&git_project_index, ); -if (defined $project) { - $action ||= 'summary'; -} else { - $action ||= 'project_list'; +if (!defined $action) { + if (defined $hash) { + $action = git_get_type($hash); + } elsif (defined $hash_base && defined $file_name) { + $action = git_get_type("$hash_base:$file_name"); + } elsif (defined $project) { + $action = 'summary'; + } else { + $action = 'project_list'; + } } if (!defined($actions{$action})) { die_error(undef, "Unknown action"); -- 1.5.1.3 ``` ## Junio C Hamano, 2007-05-10 07:43 Subject: Re: [PATCH] gitweb: choose appropriate view for file type if a= parameter missing Message-ID: <7vvef1kttk.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vvef1kttk.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20070510073207.21562.qmail@25d0c789693af2.315fe32.mid.smarden.org> ``` Thanks. ``` ## Jakub Narebski, 2007-05-13 00:32 Subject: Re: [PATCH] gitweb: choose appropriate view for file type if a= parameter missing Message-ID: URL: https://gitlist.dev/e/f25m2b%241b1%241%40sea.gmane.org In-Reply-To: <20070510073207.21562.qmail@25d0c789693af2.315fe32.mid.smarden.org> ``` [Cc: Gerrit Pape , Junio C Hamano , git@vger.kernel.org] Gerrit Pape wrote: > this change would aid the creation of shortcuts to git repositories using > simple substitution, such as: > http://example.org/git/?p=path/to/repo.git;hb=HEAD;f=%s > > With this patch, if given the hash through the h= parameter, or the hash > base (hb=) and a filename (f=), gitweb uses cat-file -t to automatically set > the a= parameter. > -if (defined $project) { > - $action ||= 'summary'; > -} else { > - $action ||= 'project_list'; > +if (!defined $action) { > + if (defined $hash) { > + $action = git_get_type($hash); > + } elsif (defined $hash_base && defined $file_name) { > + $action = git_get_type("$hash_base:$file_name"); > + } elsif (defined $project) { > + $action = 'summary'; > + } else { > + $action = 'project_list'; > + } NOTE: We have something similar for the only committag we support, namely the shortened sha1 of object, which leads to an "object", which chooses appropriate view using git_get_type / git-cat-file -t. But contrary to the above solution it does it by creating a _redirect_ to a proper view, instead of silently selecting proper view like in a patch above. Creating a redirect allows price for invoking git-cat-file -t to be paid only once. User would bookmark correct view. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git ```