# [PATCH] [TRIVIAL] Change default man page path to /usr/share/man 12 messages from 2007-05-08 to 2007-06-20. Participants: Ismail Dönmez, Uwe Kleine-König, Brian Gernhardt, Linus Torvalds, Junio C Hamano. Thread: https://gitlist.dev/t/8031 ## Ismail Dönmez, 2007-05-08 10:49 Subject: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Message-ID: <200705081349.34964.ismail@pardus.org.tr> URL: https://gitlist.dev/e/200705081349.34964.ismail%40pardus.org.tr ``` Hi, According to FHS standard default man page path is $prefix/share/man [0] , attached patch fixes this for GIT. [0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES Signed-off-by: Ismail Donmez Regards, ismail -- Le mieux est l'ennemi du bien. --- Documentation/Makefile 2007-02-26 21:20:28.000000000 +0200 +++ Documentation/Makefile 2007-02-28 01:18:07.672166995 +0200 @@ -26,7 +26,7 @@ prefix?=$(HOME) bindir?=$(prefix)/bin -mandir?=$(prefix)/man +mandir?=$(prefix)/share/man man1dir=$(mandir)/man1 man7dir=$(mandir)/man7 # DESTDIR= ``` ## Uwe Kleine-König, 2007-05-08 15:02 Subject: Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Message-ID: <20070508150220.GA18860@informatik.uni-freiburg.de> URL: https://gitlist.dev/e/20070508150220.GA18860%40informatik.uni-freiburg.de In-Reply-To: <200705081349.34964.ismail@pardus.org.tr> ``` Hallo, Ismail Dönmez wrote: > According to FHS standard default man page path is $prefix/share/man [0] , > attached patch fixes this for GIT. According to some GNU standard it's $prefix/man. E.g. autoconf managed projects use $prefix/man if you don't give --mandir=... to configure. Personally I prefer FHS, so I have mandir=$(prefix)/share/man in my config.mak. Best regards Uwe -- Uwe Kleine-König http://www.google.com/search?q=72+PS+point+in+inch ``` ## Ismail Dönmez, 2007-05-08 15:23 Subject: Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Message-ID: <200705081823.37602.ismail@pardus.org.tr> URL: https://gitlist.dev/e/200705081823.37602.ismail%40pardus.org.tr In-Reply-To: <20070508150220.GA18860@informatik.uni-freiburg.de> ``` Hi, On Tuesday 08 May 2007 18:02:20 Uwe Kleine-König wrote: > Ismail Dönmez wrote: > > According to FHS standard default man page path is $prefix/share/man [0] > > , attached patch fixes this for GIT. > > According to some GNU standard it's $prefix/man. > > E.g. autoconf managed projects use $prefix/man if you don't give > --mandir=... to configure. Just noticed one can do make mandir=/usr/share/man > Personally I prefer FHS, so I have > > mandir=$(prefix)/share/man > > in my config.mak. Same here, IMHO FHS makes more sense and AFAIK most distros uses /usr/share/man. Regards, ismail -- Le mieux est l'ennemi du bien. ``` ## Brian Gernhardt, 2007-05-08 17:44 Subject: Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Message-ID: <3AF7D319-64EC-49DD-BDBB-D438EBA0CD6A@silverinsanity.com> URL: https://gitlist.dev/e/3AF7D319-64EC-49DD-BDBB-D438EBA0CD6A%40silverinsanity.com In-Reply-To: <20070508150220.GA18860@informatik.uni-freiburg.de> ``` On May 8, 2007, at 11:02 AM, Uwe Kleine-König wrote: > Personally I prefer FHS, so I have > > mandir=$(prefix)/share/man > > in my config.mak. The Perl man files Git(3pm) and private-Error(3pm) seem to ignore that setting though. :-( I just have a "mybuild" target in config.mak that calls make all, doc, test, install, and install-doc before cleaning up files from the wrong places (man instead of share/man, Perl's System dir on OS X) and running "stow -R" to catch new files. ~~ Brian ``` ## Ismail Dönmez, 2007-05-11 17:25 Subject: Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Message-ID: <200705112025.58095.ismail@pardus.org.tr> URL: https://gitlist.dev/e/200705112025.58095.ismail%40pardus.org.tr In-Reply-To: <200705081349.34964.ismail@pardus.org.tr> ``` On Tuesday 08 May 2007 13:49:31 you wrote: > Hi, > > According to FHS standard default man page path is $prefix/share/man [0] , > attached patch fixes this for GIT. > > [0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES > > Signed-off-by: Ismail Donmez ACK? NAK? Do we care about this? :) Patch attached again for convenience. Regards, ismail -- Perfect is the enemy of good --- Documentation/Makefile 2007-02-26 21:20:28.000000000 +0200 +++ Documentation/Makefile 2007-02-28 01:18:07.672166995 +0200 @@ -26,7 +26,7 @@ prefix?=$(HOME) bindir?=$(prefix)/bin -mandir?=$(prefix)/man +mandir?=$(prefix)/share/man man1dir=$(mandir)/man1 man7dir=$(mandir)/man7 # DESTDIR= ``` ## Linus Torvalds, 2007-05-11 17:42 Subject: Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Message-ID: URL: https://gitlist.dev/e/alpine.LFD.0.98.0705111041140.3986%40woody.linux-foundation.org In-Reply-To: <200705112025.58095.ismail@pardus.org.tr> ``` On Fri, 11 May 2007, Ismail Dönmez wrote: > > ACK? NAK? Do we care about this? :) I'll Ack it, for what it's worth. As it is, I actually end up doing make prefix=/usr/local/share install-doc (or something like that) to get things in the right place. I think the old "$(prefix)/man" is just because I still mentally live in the early 90's most of the time. Linus ``` ## Junio C Hamano, 2007-05-11 19:27 Subject: Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Message-ID: <7v646zb1p4.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v646zb1p4.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <200705112025.58095.ismail@pardus.org.tr> ``` Ismail Dönmez writes: > On Tuesday 08 May 2007 13:49:31 you wrote: >> Hi, >> >> According to FHS standard default man page path is $prefix/share/man [0] , >> attached patch fixes this for GIT. >> >> [0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES >> >> Signed-off-by: Ismail Donmez > > ACK? NAK? Do we care about this? :) I would not say the patch is wrong per-se, but: - People who do not override prefix to install in $HOME would suddenly get their mandir under $HOME/share/man; the fact nobody complained so far suggests me that these people have $MANPATH pointing at $HOME/man, which means your patch breaks things for them, unless they have been overriding mandir in which case your patch does not matter to them; - Distros who package git and want to conform to FHS would have been overriding not just prefix but mandir anyway, so your patch is not an improvement to them; - People who override prefix to install locally in /usr or /usr/local does "make prefix=" thing anyway, and the fact nobody complained so far suggests me that they have already known they need to override mandir as well if they do not like /usr/local/man, so your patch is not an improvement to them. That makes one half negative plus two and half neutral. ``` ## Ismail Dönmez, 2007-05-11 19:42 Subject: Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Message-ID: <200705112242.44618.ismail@pardus.org.tr> URL: https://gitlist.dev/e/200705112242.44618.ismail%40pardus.org.tr In-Reply-To: <7v646zb1p4.fsf@assigned-by-dhcp.cox.net> ``` On Friday 11 May 2007 22:27:35 you wrote: > Ismail Dönmez writes: > > On Tuesday 08 May 2007 13:49:31 you wrote: > >> Hi, > >> > >> According to FHS standard default man page path is $prefix/share/man [0] > >> , attached patch fixes this for GIT. > >> > >> [0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES > >> > >> Signed-off-by: Ismail Donmez > > > > ACK? NAK? Do we care about this? :) > > I would not say the patch is wrong per-se, but: > > - People who do not override prefix to install in $HOME would > suddenly get their mandir under $HOME/share/man; the fact > nobody complained so far suggests me that these people have > $MANPATH pointing at $HOME/man, which means your patch breaks > things for them, unless they have been overriding mandir in > which case your patch does not matter to them; Or nobody is reading man pages? *g* > - Distros who package git and want to conform to FHS would have > been overriding not just prefix but mandir anyway, so your patch > is not an improvement to them; True that. > - People who override prefix to install locally in /usr or > /usr/local does "make prefix=" thing anyway, and the fact > nobody complained so far suggests me that they have already > known they need to override mandir as well if they do not > like /usr/local/man, so your patch is not an improvement to > them. Most(All?) distros /usr/share/man in MANPATH so I believe this patch shouldn't break anything but well you have the final say. I am ok with doing make mandir=/usr/share/man install-doc . Regards, ismail -- Perfect is the enemy of good ``` ## Junio C Hamano, 2007-05-11 19:44 Subject: Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Message-ID: <7vwszf9md5.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vwszf9md5.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <200705112242.44618.ismail@pardus.org.tr> ``` Ismail Dönmez writes: > Most(All?) distros /usr/share/man in MANPATH so I believe this > patch shouldn't break anything but well you have the final > say. I am ok with doing make mandir=/usr/share/man install-doc My preference is to do this early after 1.5.2. I do not want to touch builds with trivial changes before the final. ``` ## Ismail Dönmez, 2007-05-11 19:50 Subject: Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Message-ID: <200705112250.07340.ismail@pardus.org.tr> URL: https://gitlist.dev/e/200705112250.07340.ismail%40pardus.org.tr In-Reply-To: <7vwszf9md5.fsf@assigned-by-dhcp.cox.net> ``` On Friday 11 May 2007 22:44:06 Junio C Hamano wrote: > Ismail Dönmez writes: > > Most(All?) distros /usr/share/man in MANPATH so I believe this > > patch shouldn't break anything but well you have the final > > say. I am ok with doing make mandir=/usr/share/man install-doc > > My preference is to do this early after 1.5.2. I do not want to > touch builds with trivial changes before the final. Ok with me, thank you. Regards, ismail -- Perfect is the enemy of good ``` ## Ismail Dönmez, 2007-06-20 19:42 Subject: Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Message-ID: <200706202242.13100.ismail@pardus.org.tr> URL: https://gitlist.dev/e/200706202242.13100.ismail%40pardus.org.tr In-Reply-To: <7vwszf9md5.fsf@assigned-by-dhcp.cox.net> ``` On Friday 11 May 2007 22:44:06 Junio C Hamano wrote: > Ismail Dönmez writes: > > Most(All?) distros /usr/share/man in MANPATH so I believe this > > patch shouldn't break anything but well you have the final > > say. I am ok with doing make mandir=/usr/share/man install-doc > > My preference is to do this early after 1.5.2. I do not want to > touch builds with trivial changes before the final. Still not applied to 1.5.2.2. Patch attached for convenience. Regards, ismail -- Perfect is the enemy of good --- Documentation/Makefile 2007-02-26 21:20:28.000000000 +0200 +++ Documentation/Makefile 2007-02-28 01:18:07.672166995 +0200 @@ -26,7 +26,7 @@ prefix?=$(HOME) bindir?=$(prefix)/bin -mandir?=$(prefix)/man +mandir?=$(prefix)/share/man man1dir=$(mandir)/man1 man7dir=$(mandir)/man7 # DESTDIR= ``` ## Junio C Hamano, 2007-06-20 20:20 Subject: Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man Message-ID: <7vfy4mtm2o.fsf@assigned-by-dhcp.pobox.com> URL: https://gitlist.dev/e/7vfy4mtm2o.fsf%40assigned-by-dhcp.pobox.com In-Reply-To: <200706202242.13100.ismail@pardus.org.tr> ``` Ismail Dönmez writes: > On Friday 11 May 2007 22:44:06 Junio C Hamano wrote: >> Ismail Dönmez writes: >> > Most(All?) distros /usr/share/man in MANPATH so I believe this >> > patch shouldn't break anything but well you have the final >> > say. I am ok with doing make mandir=/usr/share/man install-doc >> >> My preference is to do this early after 1.5.2. I do not want to >> touch builds with trivial changes before the final. > > Still not applied to 1.5.2.2. Patch attached for convenience. Thanks. I do not think this patch should happen to 1.5.2.X for any value of X; but I am willing to apply it to 'master' (hence 1.5.3 and later). ```