threads / patch / 7894

patchhttp.c: Fix problem with repeated calls of http_init

Subject: [PATCH] http.c: Fix problem with repeated calls of http_init

## tl;dr

One message between Apr 29, 2007 and Apr 29, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Julian Phillips· Apr 29, 2007, 02:46 UTC · lore

Calling http_init after calling http_cleanup causes a segfault. This is due to the pragma_header curl_slist being freed but not being set to NULL. The subsequent call to http_init tries to setup the slist again, but it now points to an invalid memory location.

Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk>
---
This doesn't cause any problems in current git as far as I know.  It does however break my C fetch when using http.
 http.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to http.c +1 −0
diff --git a/http.c b/http.c
index 576740f..ae27e0c 100644
--- a/http.c
+++ b/http.c
@@ -300,6 +300,7 @@ void http_cleanup(void)
 	curl_global_cleanup();
 
 	curl_slist_free_all(pragma_header);
+        pragma_header = NULL;
 }
 
 struct active_request_slot *get_active_slot(void)
-- 
1.5.1.2

← back to recent threads