threads / patch / 7880

patchmake j/k move down/up in gitk (like vi)

Subject: [PATCH] make j/k move down/up in gitk (like vi)

## tl;dr

3 messages between Apr 28, 2007 and Apr 29, 2007. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Bart Trojanowski· Apr 28, 2007, 03:02 UTC · lore

Currently gitk has i/k bound to move up and down in the commit list. I would like to make that more consistent with vi's j/k.

If this is not acceptable, I will investigate a git-config option for vi compatibility mode.

---
 gitk |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

Show changes to gitk +2 −4

diff --git a/gitk b/gitk
index b1c65d7..0ce4a12 100755
--- a/gitk
+++ b/gitk
@@ -711,10 +711,8 @@ proc makewindow {} {
     bindkey n "selnextline 1"
     bindkey z "goback"
     bindkey x "goforw"
-    bindkey i "selnextline -1"
-    bindkey k "selnextline 1"
-    bindkey j "goback"
-    bindkey l "goforw"
+    bindkey k "selnextline -1"
+    bindkey j "selnextline 1"
     bindkey b "$ctext yview scroll -1 pages"
     bindkey d "$ctext yview scroll 18 units"
     bindkey u "$ctext yview scroll -18 units"

-- 
1.5.2.rc0.56.g6169a

Martin Waitz· Apr 28, 2007, 09:26 UTC · re: Bart Trojanowski · lore

Re: [PATCH] make j/k move down/up in gitk (like vi)

hoi :)

On Fri, Apr 27, 2007 at 11:02:15PM -0400, Bart Trojanowski wrote:

> Currently gitk has i/k bound to move up and down in the commit list.  I
> would like to make that more consistent with vi's j/k.

very nice. if you want to keep back/forward near up/down you can use h/l, just like left/right in vi.

-- 
Martin Waitz

Junio C Hamano· Apr 29, 2007, 18:13 UTC · re: Bart Trojanowski · lore

Re: [PATCH] make j/k move down/up in gitk (like vi)

Bart Trojanowski <bart@jukie.net> writes:

> Currently gitk has i/k bound to move up and down in the commit list.  I
> would like to make that more consistent with vi's j/k.

I kind of second this. Any program that implements keyboard navigation and binds directions differently from vi greatly irritates me.

But it may be just me, who never used wordstar.

> If this is not acceptable, I will investigate a git-config option for vi
> compatibility mode.

I think a sensible way to go would be to allow gitk to read a custom tcl script from $HOME/.gitk, and make sure when the file is written back, the custom bindings are stored there as well.