threads / discuss / 7868

What's cooking in git.git (topics)

Subject: What's cooking in git.git (topics)

## tl;dr

5 messages between Apr 27, 2007 and May 6, 2007.

replies: 4people: 2as markdown or json

Junio C Hamano· Apr 27, 2007, 08:24 UTC · lore

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' while commits prefixed with '+' are in 'next'. The topics list the commits in reverse chronological order.

* jc/attr (Sat Apr 21 03:14:13 2007 -0700) 2 commits
 + Add 'filter' attribute and external filter driver definition.
 + Add 'ident' conversion.

As two people on the list whose judgement on design issues I trust both say "give them rope is Ok", perhaps I should push this out to 'master' before v1.5.2-rc1. I am still worried about the rope being too long, though, and tried to describe the intent and limitation in the documentation to prevent users from hurting themselves, but I do not think the descriptions I have are good enough yet.

* jc/blame (Fri Apr 27 00:42:15 2007 -0700) 7 commits
 - Apply mailmap in git-blame output.
 - Split out mailmap handling out of shortlog
 - blame: show log as it goes
 - git-blame: optimize get_origin() from linear search to hash-
   lookup.
 - git-blame: pass "struct scoreboard *" pointers around.
 - blame: lift structure definitions up
 - blame -s: suppress author name and time.

In addition to the update to use .mailmap, this has the "log" output that uses the blame machinery Linus suggested. I think I know what more are needed to make it more pleasant to use, but the necessary changes seem a bit too involved. I might advance the topic a bit more during the stabilization period for v1.5.2, but I am planning to leave the actual merge until v1.5.3 cycle.

* lt/objalloc (Mon Apr 16 22:13:09 2007 -0700) 1 commit
 - Make the object lookup hash use a "object index" instead of a
   pointer
* jc/diff (Mon Dec 25 01:08:50 2006 -0800) 2 commits
 - test-para: combined diff between HEAD, index and working tree.
 - para-walk: walk n trees, index and working tree in parallel
These are stalled.
Junio C Hamano· Apr 29, 2007, 18:33 UTC · re: Junio C Hamano · lore

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' while commits prefixed with '+' are in 'next'. The topics list the commits in reverse chronological order.

Well, everything meant for v1.5.2 is in 'master' now. There is nothing to see here.

* jc/blame (Fri Apr 20 16:25:50 2007 -0700) 4 commits
 - blame: show log as it goes
 - git-blame: optimize get_origin() from linear search to hash-
   lookup.
 - git-blame: pass "struct scoreboard *" pointers around.
 - blame: lift structure definitions up
* lt/objalloc (Mon Apr 16 22:13:09 2007 -0700) 1 commit
 - Make the object lookup hash use a "object index" instead of a
   pointer
* jc/diff (Mon Dec 25 01:08:50 2006 -0800) 2 commits
 - test-para: combined diff between HEAD, index and working tree.
 - para-walk: walk n trees, index and working tree in parallel
Linus Torvalds· Apr 29, 2007, 18:45 UTC · re: Junio C Hamano · lore

Re: What's cooking in git.git (topics)

On Sun, 29 Apr 2007, Junio C Hamano wrote:
>
> * lt/objalloc (Mon Apr 16 22:13:09 2007 -0700) 1 commit
>  - Make the object lookup hash use a "object index" instead of a
>    pointer
I think you should just drop this. 

You merged the two patches that made this possible, and the third in the series isn't really worth it. I can re-create it at will (maybe better) now that the core object allocations are all cleaned up, and that patch simply didn't give enough of an advantage to be worth it.

Maybe inlining the object index -> ptr conversion would have solved the performance regression, but it migth also be something more fundamental, like the potential extra cache miss in the converstion part (when looking up the allocation block).

So it was interesting to try, but I don't think it's worth carrying around considering the results.

		Linus
Junio C Hamano· Apr 30, 2007, 23:20 UTC · re: Linus Torvalds · lore

Re: What's cooking in git.git (topics)

Linus Torvalds <torvalds@linux-foundation.org> writes:
Show 7 quoted lines
> On Sun, 29 Apr 2007, Junio C Hamano wrote:
>>
>> * lt/objalloc (Mon Apr 16 22:13:09 2007 -0700) 1 commit
>>  - Make the object lookup hash use a "object index" instead of a
>>    pointer
>
> I think you should just drop this. 

Yeah. I was mostly concentrating on maint/master for the past several days, and blindly carrying it around was cheaper than deciding to drop it in my workflow.

Junio C Hamano· May 6, 2007, 08:53 UTC · re: Junio C Hamano · lore

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' while commits prefixed with '+' are in 'next'. The topics list the commits in reverse chronological order.

As I have been sick and am mostly concentrating on fixes on 'master' anyway, there aren't much to see here. Indeed, 'master' and 'next' still have identical trees.

* fl/cvsserver (Wed May 2 02:45:22 2007 +0200) 1 commit
 - cvsserver: Add test cases for git-cvsserver

I need to ask k.org people to install sqlite and libdvd-sqlite-perl before I can advance this to 'next'.

* jc/blame (Fri Apr 20 16:25:50 2007 -0700) 4 commits
 - blame: show log as it goes
 - git-blame: optimize get_origin() from linear search to hash-
   lookup.
 - git-blame: pass "struct scoreboard *" pointers around.
 - blame: lift structure definitions up

← back to recent threads