threads / patch / 7861

patch, 2 partspost-receive-email example hook: sed command for getting description was wrong

Subject: [PATCH 3/2] post-receive-email example hook: sed command for getting description was wrong

## tl;dr

One message between Apr 26, 2007 and Apr 26, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Andy Parkins· Apr 26, 2007, 21:37 UTC · lore

The sed command that extracted the first line of the project description didn't include the -n switch and hence the project name was being printed twice. This was ruining the email header generation because it was assumed that the description was only one line and was included in the subject. This turned the subject into a two line item and prematurely finished the header.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
Oops - patch 3 in my series of 2.  Tee hee.
 contrib/hooks/post-receive-email |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to contrib/hooks/post-receive-email +1 −1
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index e175b42..d1bef91 100644
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -587,7 +587,7 @@ if [ -z "$GIT_DIR" ]; then
 	exit 1
 fi
 
-projectdesc=$(sed -e '1p' "$GIT_DIR/description")
+projectdesc=$(sed -ne '1p' "$GIT_DIR/description")
 # Check if the description is unchanged from it's default, and shorten it to a
 # more manageable length if it is
 if expr "$projectdesc" : "Unnamed repository.*$" >/dev/null
-- 
1.5.2.rc0.744.g33910

← back to recent threads