sorry for the bad formatting, stupid web email....
If you specify "-translation binary", it will actually set the -encoding to binary as well. From the man page http://tcl.activestate.com/man/tcl8.4/TclCmd/fconfigure.htm#M11
"binary No end-of-line translations are performed. This is nearly identical to lf mode, except that in addition binary mode also sets the end-of-file character to the empty string (which disables it) and sets the encoding to binary (which disables encoding filtering). See the description of -eofchar and -encoding for more information." Note also that Tcl stores strings internally as UTF-8. You might be working too hard (I'm not sure, I haven't looked at the code).
HTH,
--brett----- Original Message ---- From: Shawn O. Pearce <spearce@spearce.org> To: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de> Cc: Git Mailing List <git@vger.kernel.org> Sent: Monday, April 23, 2007 11:16:52 PM Subject: Re: [BUG] git gui and my ö
"Shawn O. Pearce" <spearce@spearce.org> wrote:
> Uwe Kleine-K??nig <ukleinek@informatik.uni-freiburg.de> wrote: > > commit-tree failed: > > Warning: commit message does not conform to UTF-8.
This was starting to bug me, so I went off and found it. OK, well the encoding error anyway. git-gui incorrectly claimed commit-tree failed when it didn't. But besides the point, this is the bad line:
> 1294 fconfigure $msg_wt -encoding $enc -translation binary
I have had trouble in the past with trying to use that magic -encoding flag on fconfigure to get Tcl's file channels to perform encoding work for me. Seems it doesn't work right or something... so other parts of git-gui (e.g. the filename handling parts) perform the convertfrom/convertto logic on their own... but the commit message handling parts didn't.
They do now (git gui 0.6.5-11-gf20db5f).
Can you please test my current master branch and see if that fixes things for you? repo.or.cz, git-gui.git...
If it does, I'm probably going to tag that as 0.6.6 and let Junio cut 1.5.2 with that release.
-- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com