# Re: [PATCH] Remove usernames from all commit messages, not just when using svmprops

2 messages from 2007-04-25 to 2007-04-25. Participants: Eric Wong, Adam Roben.
Thread: https://gitlist.dev/t/7823

## Adam Roben, 2007-04-25 01:02

Subject: [PATCH] Remove usernames from all commit messages, not just when using svmprops
Message-ID: <9F361BEA-54A1-479F-9552-1E2170A83DAF@apple.com>
URL: https://gitlist.dev/e/9F361BEA-54A1-479F-9552-1E2170A83DAF%40apple.com

```
Signed-off-by: Sam Vilain <sam.vilain@catalyst.net.nz>
Signed-off-by: Adam Roben <aroben@apple.com>
---
  git-svn.perl |    5 ++++-
  1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index efc4c88..077d6b3 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1866,11 +1866,14 @@ sub make_log_entry {
  	} elsif ($self->use_svnsync_props) {
  		my $full_url = $self->svnsync->{url};
  		$full_url .= "/$self->{path}" if length $self->{path};
+		remove_username($full_url);
  		my $uuid = $self->svnsync->{uuid};
  		$log_entry{metadata} = "$full_url\@$rev $uuid";
  		$email ||= "$author\@$uuid"
  	} else {
-		$log_entry{metadata} = $self->metadata_url. "\@$rev " .
+		my $url = $self->metadata_url;
+		remove_username($url);
+		$log_entry{metadata} = "$url\@$rev " .
  		                       $self->ra->get_uuid;
  		$email ||= "$author\@" . $self->ra->get_uuid;
  	}
-- 
1.5.2.rc0.14.g520d-dirty

```

## Eric Wong, 2007-04-25 01:33

Subject: Re: [PATCH] Remove usernames from all commit messages, not just when using svmprops
Message-ID: <20070425013221.GC7169@muzzle>
URL: https://gitlist.dev/e/20070425013221.GC7169%40muzzle
In-Reply-To: <9F361BEA-54A1-479F-9552-1E2170A83DAF@apple.com>

```
Adam Roben <aroben@apple.com> wrote:
> Signed-off-by: Sam Vilain <sam.vilain@catalyst.net.nz>
> Signed-off-by: Adam Roben <aroben@apple.com>

Acked-by: Eric Wong <normalperson@yhbt.net>

> ---
>  git-svn.perl |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index efc4c88..077d6b3 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1866,11 +1866,14 @@ sub make_log_entry {
>  	} elsif ($self->use_svnsync_props) {
>  		my $full_url = $self->svnsync->{url};
>  		$full_url .= "/$self->{path}" if length $self->{path};
> +		remove_username($full_url);
>  		my $uuid = $self->svnsync->{uuid};
>  		$log_entry{metadata} = "$full_url\@$rev $uuid";
>  		$email ||= "$author\@$uuid"
>  	} else {
> -		$log_entry{metadata} = $self->metadata_url. "\@$rev " .
> +		my $url = $self->metadata_url;
> +		remove_username($url);
> +		$log_entry{metadata} = "$url\@$rev " .
>  		                       $self->ra->get_uuid;
>  		$email ||= "$author\@" . $self->ra->get_uuid;
>  	}
> -- 
> 1.5.2.rc0.14.g520d-dirty

-- 
Eric Wong

```