[PATCH] Really honor umask when creating files

Junio C Hamano· Apr 17, 2005, 08:15 UTC · lore

The stated plan was to create new files with either 0666 or 0777 and let the system take care of applying umask(). Running fchmod afterwards defeats this plan, so drop it.

You still need to spell your octals with prefix in addition to this patch.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

 checkout-cache.c |    2 --
 1 files changed, 2 deletions(-)

checkout-cache.c: a87022a97c4604ef42ae6c31d641dc749a076ca3 --- checkout-cache.c +++ checkout-cache.c 2005-04-17 01:11:17.000000000 -0700

Show changes to diff +0 −2

@@ -62,8 +62,6 @@
 			fd = open(path, O_WRONLY | O_TRUNC | O_CREAT, mode);
 		}
 	}
-	if (fd >= 0)
-		fchmod(fd, mode);
 	return fd;
 }

patchReally honor umask when creating files