# [PATCH] Fix crash in t0020 (crlf conversion) 1 messages from 2007-04-22 to 2007-04-22. Participants: Alex Riesen. Thread: https://gitlist.dev/t/7778 ## Alex Riesen, 2007-04-22 14:11 Subject: [PATCH] Fix crash in t0020 (crlf conversion) Message-ID: <20070422141154.GB2431@steel.home> URL: https://gitlist.dev/e/20070422141154.GB2431%40steel.home ``` Reallocated wrong size. Noticed on Ubuntu 7.04 probably because it has some malloc diagnostics in libc: "git-read-tree --reset -u HEAD" aborted in the test. Valgrind sped up the debugging greatly: took me 10 minutes. Signed-off-by: Alex Riesen --- attr.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/attr.c b/attr.c index 285e689..a071254 100644 --- a/attr.c +++ b/attr.c @@ -300,7 +300,8 @@ static struct attr_stack *read_attr_from_array(const char **list) a = parse_attr_line(line, "[builtin]", ++lineno, 1); if (!a) continue; - res->attrs = xrealloc(res->attrs, res->num_matches + 1); + res->attrs = xrealloc(res->attrs, + sizeof(struct match_attr *) * (res->num_matches + 1)); res->attrs[res->num_matches++] = a; } return res; @@ -324,7 +325,8 @@ static struct attr_stack *read_attr_from_file(const char *path, int macro_ok) a = parse_attr_line(buf, path, ++lineno, macro_ok); if (!a) continue; - res->attrs = xrealloc(res->attrs, res->num_matches + 1); + res->attrs = xrealloc(res->attrs, + sizeof(struct match_attr *) * (res->num_matches + 1)); res->attrs[res->num_matches++] = a; } fclose(fp); -- 1.5.1.1.946.gdb75a ```