threads / patch / 774

patchConfigure encoding

Subject: [gitweb PATCH] Configure encoding

## tl;dr

6 messages between May 31, 2005 and May 31, 2005. Diffs are folded; open one to read it.

replies: 5people: 3as markdown or json

Thomas Kolejka· May 31, 2005, 07:55 UTC · lore
The following patch makes it easy to change the encoding:

--- gitweb.cgi.177 2005-05-31 09:43:17.000000000 +0200 +++ gitweb.cgi.p 2005-05-31 09:48:46.000000000 +0200

Show changes to diff +7 −6
@@ -20,6 +20,9 @@
 my $my_uri =           $cgi->url(-absolute => 1);
 my $rss_link = "";
 
+my $encoding = "utf-8";
+$encoding = "iso-8859-1";
+
 # absolute fs-path which will be prepended to the project path
 my $projectroot =      "/pub/scm";
 $projectroot = "pub/scm";
@@ -183,9 +186,9 @@
                        $title .= "/$action";
                }
        }
-       print $cgi->header(-type=>'text/html',  -charset => 'utf-8',
-status=> $status);
+       print $cgi->header(-type=>'text/html',  -charset => $encoding,
-status=> $status);
        print <<EOF;
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="$encoding"?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en-US" lang="en-US">
 <!-- git web interface v$version, (C) 2005, Kay Sievers
<kay.sievers\@vrfy.org>, Christian Gierke <ch\@gierke.de> -->
@@ -1112,8 +1115,8 @@
        my (@revlist) = map { chomp; $_ } <$fd>;
        close $fd || die_error(undef, "Reading rev-list failed.");
 
-       print $cgi->header(-type => 'text/xml', -charset => 'utf-8');
-       print "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n".
+       print $cgi->header(-type => 'text/xml', -charset => $encoding);
+       print "<?xml version=\"1.0\" encoding=\"$encoding\"?>\n".
              "<rss version=\"0.91\">\n";
        print "<channel>\n";
        print "<title>$project</title>\n".



Thomas

-- 
Weitersagen: GMX DSL-Flatrates mit Tempo-Garantie!
Ab 4,99 Euro/Monat: http://www.gmx.net/de/go/dsl
Kay Sievers· May 31, 2005, 09:19 UTC · re: Thomas Kolejka · lore

Re: [gitweb PATCH] Configure encoding

On Tue, May 31, 2005 at 09:55:11AM +0200, Thomas Kolejka wrote:
Show 11 quoted lines
> The following patch makes it easy to change the encoding:
> 
> 
> --- gitweb.cgi.177      2005-05-31 09:43:17.000000000 +0200
> +++ gitweb.cgi.p        2005-05-31 09:48:46.000000000 +0200
> @@ -20,6 +20,9 @@
>  my $my_uri =           $cgi->url(-absolute => 1);
>  my $rss_link = "";
>  
> +my $encoding = "utf-8";
> +$encoding = "iso-8859-1";

The upstream version will not support anything but the one and only sane encoding which is utf-8. It will not provide options to switch back to the 80's, sorry. :)

Thanks, Kay

Petr Baudis· May 31, 2005, 10:12 UTC · re: Kay Sievers · lore

Re: [gitweb PATCH] Configure encoding

Dear diary, on Tue, May 31, 2005 at 11:19:55AM CEST, I got a letter where Kay Sievers <kay.sievers@vrfy.org> told me that...

Show 16 quoted lines
> On Tue, May 31, 2005 at 09:55:11AM +0200, Thomas Kolejka wrote:
> > The following patch makes it easy to change the encoding:
> > 
> > 
> > --- gitweb.cgi.177      2005-05-31 09:43:17.000000000 +0200
> > +++ gitweb.cgi.p        2005-05-31 09:48:46.000000000 +0200
> > @@ -20,6 +20,9 @@
> >  my $my_uri =           $cgi->url(-absolute => 1);
> >  my $rss_link = "";
> >  
> > +my $encoding = "utf-8";
> > +$encoding = "iso-8859-1";
> 
> The upstream version will not support anything but the one and only
> sane encoding which is utf-8. It will not provide options to switch
> back to the 80's, sorry. :)
This matters mainly for commits, right?
Perhaps I should recode from current locale to utf8 in cg-commit?
-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor
Kay Sievers· May 31, 2005, 10:44 UTC · re: Petr Baudis · lore

Re: [gitweb PATCH] Configure encoding

On Tue, May 31, 2005 at 12:12:17PM +0200, Petr Baudis wrote:
Show 20 quoted lines
> Dear diary, on Tue, May 31, 2005 at 11:19:55AM CEST, I got a letter
> where Kay Sievers <kay.sievers@vrfy.org> told me that...
> > On Tue, May 31, 2005 at 09:55:11AM +0200, Thomas Kolejka wrote:
> > > The following patch makes it easy to change the encoding:
> > > 
> > > 
> > > --- gitweb.cgi.177      2005-05-31 09:43:17.000000000 +0200
> > > +++ gitweb.cgi.p        2005-05-31 09:48:46.000000000 +0200
> > > @@ -20,6 +20,9 @@
> > >  my $my_uri =           $cgi->url(-absolute => 1);
> > >  my $rss_link = "";
> > >  
> > > +my $encoding = "utf-8";
> > > +$encoding = "iso-8859-1";
> > 
> > The upstream version will not support anything but the one and only
> > sane encoding which is utf-8. It will not provide options to switch
> > back to the 80's, sorry. :)
> 
> This matters mainly for commits, right?

Yes. Also the content of the files, but fortunately they are just plain ascii most of the time. :)

> Perhaps I should recode from current locale to utf8 in cg-commit?

Everthing else than utf-8 is just a complete mess with data shared across multiple machines. All modern distributions defaulting to utf-8 anyway, so I think it is sane to recode that utf-8.

Kay
Thomas Kolejka· May 31, 2005, 11:12 UTC · re: Kay Sievers · lore

Re: [gitweb PATCH] Configure encoding

Show 32 quoted lines
> --- Ursprüngliche Nachricht ---
> Von: Kay Sievers <kay.sievers@vrfy.org>
> An: Petr Baudis <pasky@ucw.cz>
> Kopie: Thomas Kolejka <Thomas.Kolejka@gmx.at>, Git Mailing List
> <git@vger.kernel.org>
> Betreff: Re: [gitweb PATCH] Configure encoding
> Datum: Tue, 31 May 2005 12:44:25 +0200
> 
> On Tue, May 31, 2005 at 12:12:17PM +0200, Petr Baudis wrote:
> > Dear diary, on Tue, May 31, 2005 at 11:19:55AM CEST, I got a letter
> > where Kay Sievers <kay.sievers@vrfy.org> told me that...
> > > On Tue, May 31, 2005 at 09:55:11AM +0200, Thomas Kolejka wrote:
> > > > The following patch makes it easy to change the encoding:
> > > > 
> > > > 
> > > > --- gitweb.cgi.177      2005-05-31 09:43:17.000000000 +0200
> > > > +++ gitweb.cgi.p        2005-05-31 09:48:46.000000000 +0200
> > > > @@ -20,6 +20,9 @@
> > > >  my $my_uri =           $cgi->url(-absolute => 1);
> > > >  my $rss_link = "";
> > > >  
> > > > +my $encoding = "utf-8";
> > > > +$encoding = "iso-8859-1";
> > > 
> > > The upstream version will not support anything but the one and only
> > > sane encoding which is utf-8. It will not provide options to switch
> > > back to the 80's, sorry. :)
> > 
> > This matters mainly for commits, right?
> 
> Yes. Also the content of the files, but fortunately they are just plain
> ascii most of the time. :)

I've made this changes becausae the german letters like ä, ö, ... are displayed ugly in the browser.

Show 8 quoted lines
> > Perhaps I should recode from current locale to utf8 in cg-commit?
> 
> Everthing else than utf-8 is just a complete mess with data shared
> across multiple machines. All modern distributions defaulting to utf-8
> anyway, so I think it is sane to recode that utf-8.
> 
> Kay
> -
The patch is to _change_ the encoding easy .. or to leave it unchanged.
Thomas
-- 
Geschenkt: 3 Monate GMX ProMail gratis + 3 Ausgaben stern gratis
++ Jetzt anmelden & testen ++ http://www.gmx.net/de/go/promail ++
Kay Sievers· May 31, 2005, 12:21 UTC · re: Thomas Kolejka · lore

Re: [gitweb PATCH] Configure encoding

On Tue, May 31, 2005 at 01:12:36PM +0200, Thomas Kolejka wrote:
Show 35 quoted lines
> > --- Ursprüngliche Nachricht ---
> > Von: Kay Sievers <kay.sievers@vrfy.org>
> > An: Petr Baudis <pasky@ucw.cz>
> > Kopie: Thomas Kolejka <Thomas.Kolejka@gmx.at>, Git Mailing List
> > <git@vger.kernel.org>
> > Betreff: Re: [gitweb PATCH] Configure encoding
> > Datum: Tue, 31 May 2005 12:44:25 +0200
> > 
> > On Tue, May 31, 2005 at 12:12:17PM +0200, Petr Baudis wrote:
> > > Dear diary, on Tue, May 31, 2005 at 11:19:55AM CEST, I got a letter
> > > where Kay Sievers <kay.sievers@vrfy.org> told me that...
> > > > On Tue, May 31, 2005 at 09:55:11AM +0200, Thomas Kolejka wrote:
> > > > > The following patch makes it easy to change the encoding:
> > > > > 
> > > > > 
> > > > > --- gitweb.cgi.177      2005-05-31 09:43:17.000000000 +0200
> > > > > +++ gitweb.cgi.p        2005-05-31 09:48:46.000000000 +0200
> > > > > @@ -20,6 +20,9 @@
> > > > >  my $my_uri =           $cgi->url(-absolute => 1);
> > > > >  my $rss_link = "";
> > > > >  
> > > > > +my $encoding = "utf-8";
> > > > > +$encoding = "iso-8859-1";
> > > > 
> > > > The upstream version will not support anything but the one and only
> > > > sane encoding which is utf-8. It will not provide options to switch
> > > > back to the 80's, sorry. :)
> > > 
> > > This matters mainly for commits, right?
> > 
> > Yes. Also the content of the files, but fortunately they are just plain
> > ascii most of the time. :)
> 
> I've made this changes becausae the german letters like ä, ö, ... are
> displayed ugly in the browser.

So use a sane encoding in your commit-text. We don't store the encoding with the commit, so you don't have any sane other option besides using utf-8 if you don't use plain ascii.

Show 7 quoted lines
> > > Perhaps I should recode from current locale to utf8 in cg-commit?
> > 
> > Everthing else than utf-8 is just a complete mess with data shared
> > across multiple machines. All modern distributions defaulting to utf-8
> > anyway, so I think it is sane to recode that utf-8.
> 
> The patch is to _change_ the encoding easy .. or to leave it unchanged.

Exactly. Change to other encodings is not supported upstream and will not be a configuration value, sorry.

Kay

← back to recent threads