threads / patch / 7616

patchgit-clone: Error meaningfully on failed HTTP fetches of HEAD

Subject: [PATCH] git-clone: Error meaningfully on failed HTTP fetches of HEAD

## tl;dr

4 messages between Apr 11, 2007 and Apr 12, 2007. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Martin Langhoff· Apr 11, 2007, 22:05 UTC · lore

A common problem when cloning over http is that the repo has a symlink for HEAD, and apache refuses to serve symlinks by default.

Without this patch, the clone succeeds as a "bare" and "HEADless" clone, but does not give any indication that things have gone wrong.

A bare clone that fails to fetch HEAD will still complete "successfully". I'm not sure if that's expected/desired. Is a HEADless repo valid in any situation?

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
---
 git-clone.sh |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Show changes to git-clone.sh +5 −0

diff --git a/git-clone.sh b/git-clone.sh
index 513b574..ef8cd26 100755
--- a/git-clone.sh
+++ b/git-clone.sh
@@ -65,6 +65,11 @@ Perhaps git-update-server-info needs to be run there?"
 	rm -fr "$clone_tmp"
 	http_fetch "$1/HEAD" "$GIT_DIR/REMOTE_HEAD" ||
 	rm -f "$GIT_DIR/REMOTE_HEAD"
+
+	if test -z "$bare" && test ! -f "$GIT_DIR/REMOTE_HEAD"
+	then
+		die "Could not retrieve $1/HEAD - perhaps it is a symlink?"
+	fi
 }
 
 quiet=

-- 
1.5.1.106.ga32037

Junio C Hamano· Apr 12, 2007, 00:24 UTC · re: Martin Langhoff · lore

Re: [PATCH] git-clone: Error meaningfully on failed HTTP fetches of HEAD

Martin Langhoff <martin@catalyst.net.nz> writes:

Show 11 quoted lines

> A common problem when cloning over http is that the repo has
> a symlink for HEAD, and apache refuses to serve symlinks by
> default.
>
> Without this patch, the clone succeeds as a "bare" and "HEADless"
> clone, but does not give any indication that things have gone
> wrong.
>
> A bare clone that fails to fetch HEAD will still complete
> "successfully". I'm not sure if that's expected/desired. Is a
> HEADless repo valid in any situation?

You would get "fatal: Not a git repository". Why not default to 'master' (if found) and issue a warning?

Martin Langhoff· Apr 12, 2007, 00:28 UTC · re: Junio C Hamano · lore

Re: [PATCH] git-clone: Error meaningfully on failed HTTP fetches of HEAD

Junio C Hamano wrote:

Show 6 quoted lines

>> A bare clone that fails to fetch HEAD will still complete
>> "successfully". I'm not sure if that's expected/desired. Is a
>> HEADless repo valid in any situation?
> 
> You would get "fatal: Not a git repository".  Why not default to
> 'master' (if found) and issue a warning?

And if not found die() for real...? Ok. I'll rework and resend.

cheers,

-- 
-----------------------------------------------------------------------
Martin @ Catalyst .Net .NZ  Ltd, PO Box 11-053, Manners St,  Wellington
WEB: http://catalyst.net.nz/           PHYS: Level 2, 150-154 Willis St
OFFICE: +64(4)916-7224  UK: 0845 868 5733 ext 7224  MOB: +64(21)364-017
      Make things as simple as possible, but no simpler - Einstein
-----------------------------------------------------------------------

Junio C Hamano· Apr 12, 2007, 00:38 UTC · re: Martin Langhoff · lore

Re: [PATCH] git-clone: Error meaningfully on failed HTTP fetches of HEAD

Martin Langhoff <martin@catalyst.net.nz> writes:

Show 9 quoted lines

> Junio C Hamano wrote:
>>> A bare clone that fails to fetch HEAD will still complete
>>> "successfully". I'm not sure if that's expected/desired. Is a
>>> HEADless repo valid in any situation?
>> 
>> You would get "fatal: Not a git repository".  Why not default to
>> 'master' (if found) and issue a warning?
>
> And if not found die() for real...? Ok. I'll rework and resend.

Yeah, after making sure we have 'master' there, though ;-).