# Minor git-archive bug

3 messages from 2007-04-05 to 2007-04-05. Participants: Jeff Garzik, René Scharfe, Junio C Hamano.
Thread: https://gitlist.dev/t/7522

## Jeff Garzik, 2007-04-05 11:27

Subject: Minor git-archive bug
Message-ID: <4614DD0C.50600@garzik.org>
URL: https://gitlist.dev/e/4614DD0C.50600%40garzik.org

```
"git-archive --list" requires a git repository.  Certainly listing the 
archive formats doesn't /really/ require such things.

	Jeff

```

## René Scharfe, 2007-04-05 20:55

Subject: [PATCH] Revert "builtin-archive: use RUN_SETUP"
Message-ID: <4615624F.50504@lsrfire.ath.cx>
URL: https://gitlist.dev/e/4615624F.50504%40lsrfire.ath.cx
In-Reply-To: <4614DD0C.50600@garzik.org>

```
Commit 64edf4b2 cleaned up the initialization of git-archive,
at the cost of 'git-archive --list' now requiring a git repo.
This patch reverts the cleanup and documents the requirement
for this particular dirtyness in a test.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---

Jeff Garzik schrieb:
> "git-archive --list" requires a git repository.  Certainly listing the
> archive formats doesn't /really/ require such things.

 builtin-archive.c   |    2 ++
 git.c               |    2 +-
 t/t5000-tar-tree.sh |    4 ++++
 3 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/builtin-archive.c b/builtin-archive.c
index 2fae885..8ea6cb1 100644
--- a/builtin-archive.c
+++ b/builtin-archive.c
@@ -252,6 +252,8 @@ int cmd_archive(int argc, const char **argv, const char *prefix)
 
 	memset(&ar, 0, sizeof(ar));
 	tree_idx = parse_archive_args(argc, argv, &ar);
+	if (prefix == NULL)
+		prefix = setup_git_directory();
 
 	argv += tree_idx;
 	parse_treeish_arg(argv, &ar.args, prefix);
diff --git a/git.c b/git.c
index 5b1bc2a..33dd4d3 100644
--- a/git.c
+++ b/git.c
@@ -226,7 +226,7 @@ static void handle_internal_command(int argc, const char **argv, char **envp)
 		{ "add", cmd_add, RUN_SETUP | NOT_BARE },
 		{ "annotate", cmd_annotate, USE_PAGER },
 		{ "apply", cmd_apply },
-		{ "archive", cmd_archive, RUN_SETUP },
+		{ "archive", cmd_archive },
 		{ "blame", cmd_blame, RUN_SETUP },
 		{ "branch", cmd_branch, RUN_SETUP },
 		{ "bundle", cmd_bundle },
diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh
index ac835fe..b4359df 100755
--- a/t/t5000-tar-tree.sh
+++ b/t/t5000-tar-tree.sh
@@ -130,4 +130,8 @@ test_expect_success \
     'validate file contents with prefix' \
     'diff -r a e/prefix/a'
 
+test_expect_success \
+    'git-archive --list outside of a git repo' \
+    'GIT_DIR=some/non-existing/directory git-archive --list'
+
 test_done

```

## Junio C Hamano, 2007-04-05 21:37

Subject: Re: [PATCH] Revert "builtin-archive: use RUN_SETUP"
Message-ID: <7vd52io64c.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vd52io64c.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <4615624F.50504@lsrfire.ath.cx>

```
Thanks.

```