threads / patch / 740

patchgit-tar-tree: cleanup trailer writing

Subject: [PATCH] git-tar-tree: cleanup trailer writing

## tl;dr

One message between May 27, 2005 and May 27, 2005. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Rene Scharfe· May 27, 2005, 21:16 UTC · lore
Replace open-coded variants of get_record().
Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Show changes to diff +5 −8
Index: tar-tree.c
===================================================================
--- ba1de5878d8e0cd1c7c728379e033ea6bf8567e5/tar-tree.c  (mode:100644)
+++ fa5c736eeabbead4a4c024051d104930d836092a/tar-tree.c  (mode:100644)
@@ -73,16 +73,13 @@
  */
 static void write_trailer(void)
 {
-	memset(block + offset, 0, RECORDSIZE);
-	offset += RECORDSIZE;
+	get_record();
 	write_if_needed();
-	memset(block + offset, 0, RECORDSIZE);
-	offset += RECORDSIZE;
+	get_record();
 	write_if_needed();
-	if (offset) {
-		memset(block + offset, 0, BLOCKSIZE - offset);
-		reliable_write(block, BLOCKSIZE);
-		offset = 0;
+	while (offset) {
+		get_record();
+		write_if_needed();
 	}
 }
 

← back to recent threads