threads / patch / 7331

patch, 4 partsupdate-hook: show the contents of the tag message for annotated tags

Subject: [PATCH 2/4] update-hook: show the contents of the tag message for annotated tags

## tl;dr

4 messages between Mar 20, 2007 and Mar 20, 2007. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Andy Parkins· Mar 20, 2007, 10:58 UTC · lore

The annotated tag points at a commit, for which we show the short log. However, the tag itself contains a message, possibly release notes or hand-written change log - whatever it contains is worth showing. The tag message is extracted with

  git cat-file tag $newrev | tail -q -n +5

Which is dangerously reliant on the format of the tag object being four header lines then the message. I don't like it, but I don't know of any other way of extracting the message. It's also missing any kind of support for the GPG signature.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
 templates/hooks--update |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
Show changes to templates/hooks--update +7 −1
diff --git a/templates/hooks--update b/templates/hooks--update
index 1a60773..31e72ca 100644
--- a/templates/hooks--update
+++ b/templates/hooks--update
@@ -231,8 +231,14 @@ case "$refname_type" in
 
 		echo ""
 		echo $LOGBEGIN
-		echo ""
 
+		# Show the content of the tag message; this might contain a change log
+		# or release notes so is worth displaying.  "tail -n +5" is there to
+		# remove the first 4 lines of the tag object, those details have
+		# already been summarised above
+		git cat-file tag $newrev | tail -q -n +5
+
+		echo ""
 		if [ -n "$prevtag" ]; then
 			git rev-list --pretty=short "$prevtag..$newrev" | git shortlog
 		else
-- 
1.5.0.3.402.g0c48
Martin Waitz· Mar 20, 2007, 12:41 UTC · re: Andy Parkins · lore

Re: [PATCH 2/4] update-hook: show the contents of the tag message for annotated tags

hoi :)
On Tue, Mar 20, 2007 at 10:58:38AM +0000, Andy Parkins wrote:
>   git cat-file tag $newrev | tail -q -n +5
> 
> Which is dangerously reliant on the format of the tag object being four
> header lines then the message.
I think you can split at the blank line after the header.
-- 
Martin Waitz
Andy Parkins· Mar 20, 2007, 15:27 UTC · re: Martin Waitz · lore

Re: [PATCH 2/4] update-hook: show the contents of the tag message for annotated tags

On Tuesday 2007 March 20 12:41, Martin Waitz wrote:
> > Which is dangerously reliant on the format of the tag object being four
> > header lines then the message.
>
> I think you can split at the blank line after the header.

That's a good idea; I can't think of an efficient way of doing that in shell script though. What I need is a

 grep --everything-after "^$"
:-)
Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
Shawn O. Pearce· Mar 20, 2007, 15:36 UTC · re: Andy Parkins · lore

Re: [PATCH 2/4] update-hook: show the contents of the tag message for annotated tags

Andy Parkins <andyparkins@gmail.com> wrote:
Show 11 quoted lines
> On Tuesday 2007 March 20 12:41, Martin Waitz wrote:
> 
> > > Which is dangerously reliant on the format of the tag object being four
> > > header lines then the message.
> >
> > I think you can split at the blank line after the header.
> 
> That's a good idea; I can't think of an efficient way of doing that in shell 
> script though.  What I need is a 
> 
>  grep --everything-after "^$"
	sed -e '1,/^$/d'
Portable too.  ;-)
-- 
Shawn.

← back to recent threads