threads / patch / 7328

patch, 4 partsupdate-hook: abort early if the project description is unset

Subject: [PATCH 1/4] update-hook: abort early if the project description is unset

## tl;dr

One message between Mar 20, 2007 and Mar 20, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Andy Parkins· Mar 20, 2007, 10:58 UTC · lore

It was annoying to always have the first email from a project be from the "Unnamed repository; edit this file to name it for gitweb project"; just because it's so easy to forget to set it.

This patch checks to see if the description file is still default (or empty) and aborts if so - allowing you to fix the problem before sending out silly looking emails to every developer.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
 templates/hooks--update |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
Show changes to templates/hooks--update +6 −0
diff --git a/templates/hooks--update b/templates/hooks--update
index 8f6c4fe..1a60773 100644
--- a/templates/hooks--update
+++ b/templates/hooks--update
@@ -56,6 +56,12 @@ recipients=$(git-repo-config hooks.mailinglist)
 announcerecipients=$(git-repo-config hooks.announcelist)
 allowunannotated=$(git-repo-config --bool hooks.allowunannotated)
 
+# check for no description
+if [ -z "$projectdesc" -o "$projectdesc" = "Unnamed repository; edit this file to name it for gitweb" ]; then
+	echo "*** Project description file hasn't been set" >&2
+	exit 1
+fi
+
 # --- Check types
 newrev_type=$(git-cat-file -t $newrev)
 
-- 
1.5.0.3.402.g0c48

← back to recent threads