threads / patch / 7266

patchgitweb: Fix uninitialized value when commit message is missing.

Subject: [PATCH] gitweb: Fix uninitialized value when commit message is missing.

## tl;dr

One message between Mar 16, 2007 and Mar 16, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Ed Swarthout· Mar 16, 2007, 04:55 UTC · lore
Signed-off-by: Ed Swarthout <Ed.Swarthout@freescale.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to gitweb/gitweb.perl +1 −1
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 27b5970..4771689 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1346,7 +1346,7 @@ sub parse_commit_text {
 			last;
 		}
 	}
-	if ($co{'title'} eq "") {
+	if (!defined($co{'title'}) || $co{'title'} eq "") {
 		$co{'title'} = $co{'title_short'} = '(no commit message)';
 	}
 	# remove added spaces
-- 
1.5.0.4.403.g4ee1

← back to recent threads