threads / patch / 7256

patchcogito: Escape $* in cg admin-setuprepro to fix problems with older bash versions

Subject: [PATCH] cogito: Escape $* in cg admin-setuprepro to fix problems with older bash versions

## tl;dr

One message between Mar 15, 2007 and Mar 15, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

mcdmx· Mar 15, 2007, 13:53 UTC · lore

Using $* in the _Here_ document at the end of cg-admin-setuprepro seriously confuses Bash v2.0.5b and causes lines produced by the _Here_ document to look something like

##  EEnnaabbllee ggiitt--uuppddaattee--sseerrvveerr--iinnffoo

The problem does not occur with Bash 3.1.x. The patch below fixes this by escaping the dollar in "$*".

Show changes to cg-admin-setuprepo +1 −1
diff --git a/cg-admin-setuprepo b/cg-admin-setuprepo
index d407798..a37b6ae 100755
--- a/cg-admin-setuprepo
+++ b/cg-admin-setuprepo
@@ -91,7 +91,7 @@ fi
 _git="$uri"
 cat <<_SCRIPT_EOF_ | $shell $shellarg

-die() { echo "$*" >&2; exit 1; }
+die() { echo "\$*" >&2; exit 1; }

 export GIT_DIR="$uri"

← back to recent threads