# [PATCH] Fix off-by-one error in show-diff 1 messages from 2005-04-17 to 2005-04-17. Participants: Junio C Hamano. Thread: https://gitlist.dev/t/72 ## Junio C Hamano, 2005-04-17 05:56 Subject: [PATCH] Fix off-by-one error in show-diff Message-ID: <7vsm1q0wvm.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vsm1q0wvm.fsf%40assigned-by-dhcp.cox.net ``` The patch to introduce shell safety to show-diff has an off-by-one error. Here is an fix. Signed-off-by: Junio C Hamano --- show-diff.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) show-diff.c: 8a24ff62b85a6e23469e3f0e7a20170dfe543ebf --- show-diff.c +++ show-diff.c 2005-04-16 22:53:11.000000000 -0700 @@ -27,8 +27,8 @@ int cnt, c; char *cp; - /* count single quote characters */ - for (cnt = 0, cp = src; *cp; cnt++, cp++) + /* count bytes needed to store the quoted string. */ + for (cnt = 1, cp = src; *cp; cnt++, cp++) if (*cp == '\'') cnt += 3; ```