threads / patch / 7169

patchAdd an empty line before signed-off-by

Subject: [StGit PATCH] Add an empty line before signed-off-by

## tl;dr

3 messages between Mar 9, 2007 and Mar 12, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Robin Rosenberg· Mar 9, 2007, 23:00 UTC · lore

Default to the standard convention of having an empty line before the Signed-off line when addign a signature using the --sign option.

Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
---

 stgit/commands/refresh.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to stgit/commands/refresh.py +1 −1

diff --git a/stgit/commands/refresh.py b/stgit/commands/refresh.py
index 4cf09ae..dbcb757 100644
--- a/stgit/commands/refresh.py
+++ b/stgit/commands/refresh.py
@@ -108,7 +108,7 @@ def func(parser, options, args):
         options.authname, options.authemail = name_email(options.author)
 
     if options.sign:
-        sign_str = 'Signed-off-by'
+        sign_str = '\nSigned-off-by'
         if options.ack:
             raise CmdException, '--ack and --sign were both specified'
     elif options.ack:

Catalin Marinas· Mar 12, 2007, 16:25 UTC · re: Robin Rosenberg · lore

Re: [StGit PATCH] Add an empty line before signed-off-by

On 09/03/07, Robin Rosenberg <robin.rosenberg@dewire.com> wrote:

> Default to the standard convention of having an empty line
> before the Signed-off line when addign a signature using the
> --sign option.

I mainly use this option to counter-sign an existing patch, in which case there is no need for a new line. Maybe we need StGIT to be smarter and check whether the patch was already signed.

-- 
Catalin

Robin Rosenberg· Mar 12, 2007, 21:13 UTC · re: Catalin Marinas · lore

Re: [StGit PATCH] Add an empty line before signed-off-by

    Default to the standard convention of having an empty line
    before the Signed-off line when addign a signature using the
    --sign option.

    Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
--

måndag 12 mars 2007 17:25 skrev Catalin Marinas:

Show 8 quoted lines

> On 09/03/07, Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> > Default to the standard convention of having an empty line
> > before the Signed-off line when addign a signature using the
> > --sign option.
> 
> I mainly use this option to counter-sign an existing patch, in which
> case there is no need for a new line. Maybe we need StGIT to be
> smarter and check whether the patch was already signed.

Ok, here's a smarter version

-- robin

Show changes to stgit/stack.py +6 −1

diff --git a/stgit/stack.py b/stgit/stack.py
index feb77e3..681da5e 100644
--- a/stgit/stack.py
+++ b/stgit/stack.py
@@ -734,7 +734,12 @@ class Series(StgitObject):
             committer_email = patch.get_commemail()

         if sign_str:
-            descr = '%s\n%s: %s <%s>\n' % (descr.rstrip(), sign_str,
+            descr = descr.rstrip()
+            if descr.find("\nSigned-off-by") < 0:
+                if descr.find("\nAcked-by") < 0:
+                    descr = descr + "\n"
+
+            descr = '%s\n%s: %s <%s>\n' % (descr, sign_str,
                                            committer_name, committer_email)

         bottom = patch.get_bottom()