threads / patch / 7141

patch, 5 partsMove post-update hook to after all other activity

Subject: [PATCH 1/5] Move post-update hook to after all other activity

## tl;dr

One message between Mar 7, 2007 and Mar 7, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Shawn O. Pearce· Mar 7, 2007, 21:50 UTC · lore

As the post-update hook is meant to run after we have completed the receipt of the pushed changes, and it might actually try to kick off a `repack -a -d`, we should delay on invoking it until after we have removed the *.keep file on the uploaded pack (if we kept the pack).

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 receive-pack.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
Show changes to receive-pack.c +1 −2
diff --git a/receive-pack.c b/receive-pack.c
index dda9854..d39aeba 100644
--- a/receive-pack.c
+++ b/receive-pack.c
@@ -206,12 +206,10 @@ static void run_update_post_hook(struct command *cmd)
 static void execute_commands(void)
 {
 	struct command *cmd = commands;
-
 	while (cmd) {
 		update(cmd);
 		cmd = cmd->next;
 	}
-	run_update_post_hook(commands);
 }
 
 static void read_head_info(void)
@@ -456,6 +454,7 @@ int main(int argc, char **argv)
 			unlink(pack_lockfile);
 		if (report_status)
 			report(unpack_status);
+		run_update_post_hook(commands);
 	}
 	return 0;
 }
-- 
1.5.0.3.895.g09890

← back to recent threads