Shawn O. PearceThis failure to catch the failure of write_ref_sha1 was noticed by Bill Lear. The ref will not update if the log file could not be appended to (due to file permissions problems). Such a failure should be flagged as a failure to update the ref, so that the client knows the push did not succeed.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org> --- receive-pack.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
Show changes to receive-pack.c +4 −1
diff --git a/receive-pack.c b/receive-pack.c index 7f1dcc0..dda9854 100644 --- a/receive-pack.c +++ b/receive-pack.c @@ -158,7 +158,10 @@ static int update(struct command *cmd) cmd->error_string = "failed to lock"; return error("failed to lock %s", name); } - write_ref_sha1(lock, new_sha1, "push"); + if (write_ref_sha1(lock, new_sha1, "push")) { + cmd->error_string = "failed to write"; + return -1; /* error() already called */ + } fprintf(stderr, "%s: %s -> %s\n", name, old_hex, new_hex); } return 0;
-- 1.5.0.3.895.g09890