threads / patch / 7125

patch, 9 partsmisc. cleanups

Subject: [PATCH 0/9] misc. cleanups

## tl;dr

One message between Mar 7, 2007 and Mar 7, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Shawn O. Pearce· Mar 7, 2007, 01:44 UTC · lore

This is a series of various cleanups that I have pending at the front of my pack v4 topic. The earlier ones are annoying nits, the later ones fix compiler errors caused by compiling with:

--snip--
  CFLAGS += -Wall -ansi -pedantic -std=c99
  
  ifdef strict
          CFLAGS += -Werror
          CFLAGS += -Wfour-char-constants
          CFLAGS += -fnon-lvalue-assign
          CFLAGS += -Wdeclaration-after-statement
          CFLAGS += -Wpointer-arith
          CFLAGS += -Wbad-function-cast
          CFLAGS += -Wcast-align
          CFLAGS += -Wwrite-strings
          CFLAGS += -Wshorten-64-to-32
  
          # No, currently a huge set.
          #CFLAGS += -Wsign-compare
  
          # No, only in diffcore-rename and that's ok.
          #CFLAGS += -Wfloat-equal
  
          # No, unused parameters, -Wsign-compare, missing initializers.
          # CFLAGS += -Wextra
  
          # No, memcmp trips on signed/unsigned conversion.
          # CFLAGS += -Wconversion
  endif
--snap--
-- 
Shawn.

← back to recent threads