[PATCH 1/9] Display the null SHA-1 as the base for an OBJ_OFS_DELTA.

Shawn O. Pearce· Mar 7, 2007, 01:44 UTC · lore

Because we are currently cheating and never supplying the delta base for an OBJ_OFS_DELTA we get a random SHA-1 in the delta base field. Instead lets clear the hash out so its at least all 0's. This is somewhat more obvious that something fishy is going on, like we don't actually have the SHA-1 of the base handy. :)

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 sha1_file.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to sha1_file.c +1 −0

diff --git a/sha1_file.c b/sha1_file.c
index 6d0a72e..c13ef66 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -1200,6 +1200,7 @@ const char *packed_object_info_detail(struct packed_git *p,
 			obj_offset = get_delta_base(p, &w_curs, &curpos, type, obj_offset);
 			if (*delta_chain_length == 0) {
 				/* TODO: find base_sha1 as pointed by curpos */
+				hashclr(base_sha1);
 			}
 			break;
 		case OBJ_REF_DELTA:

-- 
1.5.0.3.863.gf0989

patch, 9 partsDisplay the null SHA-1 as the base for an OBJ_OFS_DELTA.