# [PATCH] More build output cleaning up 4 messages from 2007-03-06 to 2007-03-12. Participants: Alex Riesen, Sergey Vlasov. Thread: https://gitlist.dev/t/7120 ## Alex Riesen, 2007-03-06 23:13 Subject: [PATCH] More build output cleaning up Message-ID: <81b0412b0703061513g7aafc9daq46feea69d969089a@mail.gmail.com> URL: https://gitlist.dev/e/81b0412b0703061513g7aafc9daq46feea69d969089a%40mail.gmail.com ``` - print output file name for .c files - suppress output of the names of subdirectories when make changes into them - use GEN prefix for makefile generation in perl/ Signed-off-by: Alex Riesen --- Makefile | 8 +++++--- perl/Makefile | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) From 76d21c5a5a0dacfc09ed18f72b45c3f1fc174b0c Mon Sep 17 00:00:00 2001 From: Alex Riesen Date: Tue, 6 Mar 2007 23:37:18 +0100 Subject: [PATCH] More build output cleaning up - print output file name for .c files - suppress output of the names of subdirectories when make changes into them - use GEN prefix for makefile generation in perl/ Signed-off-by: Alex Riesen --- Makefile | 8 +++++--- perl/Makefile | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 72d4291..eb6c421 100644 --- a/Makefile +++ b/Makefile @@ -605,14 +605,16 @@ ifdef NO_PERL_MAKEMAKER export NO_PERL_MAKEMAKER endif ifndef V - QUIET_CC = @echo ' ' CC $<; + QUIET_CC = @echo ' ' CC $@; QUIET_AR = @echo ' ' AR $@; QUIET_LINK = @echo ' ' LINK $@; QUIET_BUILT_IN = @echo ' ' BUILTIN $@; QUIET_GEN = @echo ' ' GEN $@; QUIET_SUBDIR0 = @subdir= - QUIET_SUBDIR1 = ;echo ' ' SUBDIR $$subdir; $(MAKE) -C$$subdir + QUIET_SUBDIR1 = ;echo ' ' SUBDIR $$subdir; \ + $(MAKE) --no-print-directory -C $$subdir export V + export QUIET_GEN else QUIET_SUBDIR0 = $(MAKE) -C QUIET_SUBDIR1 = @@ -685,7 +687,7 @@ $(patsubst %.sh,%,$(SCRIPT_SH)) : % : %.sh $(patsubst %.perl,%,$(SCRIPT_PERL)): perl/perl.mak perl/perl.mak: GIT-CFLAGS - $(MAKE) -C perl PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' $(@F) + $(QUIET_SUBDIR0)perl $(QUIET_SUBDIR1) PERL_PATH='$(PERL_PATH_SQ)' prefix='$(prefix_SQ)' $(@F) $(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl $(QUIET_GEN)rm -f $@ $@+ && \ diff --git a/perl/Makefile b/perl/Makefile index 17d004e..5ec0389 100644 --- a/perl/Makefile +++ b/perl/Makefile @@ -33,7 +33,7 @@ $(makfile): ../GIT-CFLAGS Makefile echo ' echo $(instdir_SQ)' >> $@ else $(makfile): Makefile.PL ../GIT-CFLAGS - '$(PERL_PATH_SQ)' $< PREFIX='$(prefix_SQ)' + $(QUIET_GEN)'$(PERL_PATH_SQ)' $< PREFIX='$(prefix_SQ)' endif # this is just added comfort for calling make directly in perl dir -- 1.5.0.3.410.gca42 ``` ## Alex Riesen, 2007-03-06 23:19 Subject: Re: [PATCH] More build output cleaning up Message-ID: <81b0412b0703061519h17ddc517rb11499893dda6ac5@mail.gmail.com> URL: https://gitlist.dev/e/81b0412b0703061519h17ddc517rb11499893dda6ac5%40mail.gmail.com In-Reply-To: <81b0412b0703061513g7aafc9daq46feea69d969089a@mail.gmail.com> ``` Oh, damn... I did it again. Stupid gmail... I'll try to resend them from my home account, but that probably wont work (it never did). Vger (or whatever else) keeps dropping them. ``` ## Sergey Vlasov, 2007-03-11 15:48 Subject: Re: [PATCH] More build output cleaning up Message-ID: <20070311184827.a98691c3.vsu@altlinux.ru> URL: https://gitlist.dev/e/20070311184827.a98691c3.vsu%40altlinux.ru In-Reply-To: <81b0412b0703061513g7aafc9daq46feea69d969089a@mail.gmail.com> ``` On Wed, 7 Mar 2007 00:13:08 +0100 Alex Riesen wrote: > - print output file name for .c files > - suppress output of the names of subdirectories when make changes into them > - use GEN prefix for makefile generation in perl/ > > Signed-off-by: Alex Riesen > --- > Makefile | 8 +++++--- > perl/Makefile | 2 +- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Makefile b/Makefile > index 72d4291..eb6c421 100644 > --- a/Makefile > +++ b/Makefile > @@ -605,14 +605,16 @@ ifdef NO_PERL_MAKEMAKER > export NO_PERL_MAKEMAKER > endif > ifndef V > - QUIET_CC = @echo ' ' CC $<; > + QUIET_CC = @echo ' ' CC $@; > QUIET_AR = @echo ' ' AR $@; > QUIET_LINK = @echo ' ' LINK $@; > QUIET_BUILT_IN = @echo ' ' BUILTIN $@; > QUIET_GEN = @echo ' ' GEN $@; > QUIET_SUBDIR0 = @subdir= > - QUIET_SUBDIR1 = ;echo ' ' SUBDIR $$subdir; $(MAKE) -C$$subdir > + QUIET_SUBDIR1 = ;echo ' ' SUBDIR $$subdir; \ > + $(MAKE) --no-print-directory -C $$subdir Using --no-print-directory will break movement to the location of an error/warning message at least in vim (emacs will probably have problems too), if the error is in some file in a subdirectory. The problem is that the nested make will output paths relative to the subdirectory, but without "Entering directory..." messages the editor will not know that filenames should be interpreted relative to that subdirectory. Currently this problem is not visible, because subdirectories with their own Makefiles (perl/ and git-gui/) do not contain C code - but the problem will appear, e.g., if Git.xs will be added again. ``` ## Alex Riesen, 2007-03-12 09:04 Subject: Re: [PATCH] More build output cleaning up Message-ID: <81b0412b0703120204m2d7a543ep3eec68a580f595ff@mail.gmail.com> URL: https://gitlist.dev/e/81b0412b0703120204m2d7a543ep3eec68a580f595ff%40mail.gmail.com In-Reply-To: <20070311184827.a98691c3.vsu@altlinux.ru> ``` On 3/11/07, Sergey Vlasov wrote: > > Using --no-print-directory will break movement to the location of an > error/warning message at least in vim (emacs will probably have > problems too), if the error is in some file in a subdirectory. The You can setup the make command-line to contain -w. It will work for git and for any other project you may have. ```