threads / patch / 7086

patch, 3 partsfsck: fix broken loose object check.

Subject: [PATCH 1/3] fsck: fix broken loose object check.

## tl;dr

One message between Mar 5, 2007 and Mar 5, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Junio C Hamano· Mar 5, 2007, 08:21 UTC · lore

When "git fsck" without --full found a loose object missing because it was broken, it mistakenly thought it was not parsed because we found it in one of the packs. Back when this code was written, we did not have a way to explicitly check if we have the object in pack, but we do now.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 builtin-fsck.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to builtin-fsck.c +1 −1
diff --git a/builtin-fsck.c b/builtin-fsck.c
index 6abf498..abdd0f2 100644
--- a/builtin-fsck.c
+++ b/builtin-fsck.c
@@ -67,7 +67,7 @@ static void check_reachable_object(struct object *obj)
 	 * do a full fsck
 	 */
 	if (!obj->parsed) {
-		if (has_sha1_file(obj->sha1))
+		if (has_sha1_pack(obj->sha1, NULL))
 			return; /* it is in pack - forget about it */
 		printf("missing %s %s\n", typename(obj->type), sha1_to_hex(obj->sha1));
 		return;
-- 
1.5.0.3.855.ga3b2

← back to recent threads