threads / discuss / 7082

Sending a thread of patches

Subject: Sending a thread of patches

## tl;dr

5 messages between Mar 4, 2007 and Mar 5, 2007.

replies: 4people: 3as markdown or json

Panagiotis Issaris· Mar 4, 2007, 23:00 UTC · lore

Hi,

I am trying to send a thread of patches to a mailinglist but the e-mails do not show up as one thread in some mailclients. Gmane shows the patches nicely in one thread [1], but Thunderbird shows all of them _except one_ as a thread. E-mail [PATCH 02/31] does not show up in the thread but beside it. The CC-ed emails which arrived in my inbox do not appear in one thread either, half of them do end up in one thread, the other half don't. This is possibly (most likely?) a Thunderbird problem as the e-mails appear alright in Mutt, but I was wondering if other people had noticed similar problems with Thunderbird+git-format-patch+git-send-email and if they might have some workarounds. Or, if someone might notice that I am just using incorrect parameters for both commands.

These are the commands I used: git format-patch --thread --attach -n origin..or2 git-send-email --no-chain-reply-to --to ffmpeg-devel@mplayerhq.hu --from takis.issaris@uhasselt.be --subject "[PATCH 00/31] Various Doxygen related patches" --suppress-from --compose 00*patch

With friendly regards, Takis

[1] http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/45715

Johannes Schindelin· Mar 4, 2007, 23:44 UTC · re: Panagiotis Issaris · lore

Re: Sending a thread of patches

Hi,

On Mon, 5 Mar 2007, Panagiotis Issaris wrote:

Show 5 quoted lines

> I am trying to send a thread of patches to a mailinglist but the e-mails do
> not show up as one thread in some mailclients.
> Gmane shows the patches nicely in one thread [1], but Thunderbird shows all of
> them _except one_ as a thread. E-mail [PATCH 02/31]
> does not show up in the thread but beside it.

This might be related to the fact that you have two (!) In-Reply-To: headers. See:

http://article.gmane.org/gmane.comp.video.ffmpeg.devel/45716/raw

to verify.

Show 5 quoted lines

> These are the commands I used:
> git format-patch --thread --attach -n origin..or2
> git-send-email --no-chain-reply-to --to ffmpeg-devel@mplayerhq.hu  --from
> takis.issaris@uhasselt.be --subject "[PATCH 00/31] Various Doxygen related
> patches"  --suppress-from --compose 00*patch

I have the impression from reading git-send-email that a second 
In-Reply-To: header is set if --chain-reply-to _or_ no --in-reply-to is 
specified. Since you do not have an --in-reply-to in your command line, I 
guess it is that.

However, I do not claim that I understand _why_ this is the behaviour, nor that I ever used git-send-email.

Ciao, Dscho

Julian Phillips· Mar 4, 2007, 23:56 UTC · re: Panagiotis Issaris · lore

Re: Sending a thread of patches

On Mon, 5 Mar 2007, Panagiotis Issaris wrote:

Show 20 quoted lines

> Hi,
>
> I am trying to send a thread of patches to a mailinglist but the e-mails do 
> not show up as one thread in some mailclients.
> Gmane shows the patches nicely in one thread [1], but Thunderbird shows all 
> of them _except one_ as a thread. E-mail [PATCH 02/31]
> does not show up in the thread but beside it. The CC-ed emails which arrived 
> in my inbox do not appear in one thread either, half of
> them do end up in one thread, the other half don't. This is possibly (most 
> likely?) a Thunderbird problem as the e-mails appear alright in Mutt,
> but I was wondering if other people had noticed similar problems with 
> Thunderbird+git-format-patch+git-send-email and if they might have some
> workarounds. Or, if someone might  notice that I am just using incorrect 
> parameters for both commands.
>
> These are the commands I used:
> git format-patch --thread --attach -n origin..or2
> git-send-email --no-chain-reply-to --to ffmpeg-devel@mplayerhq.hu  --from 
> takis.issaris@uhasselt.be --subject "[PATCH 00/31] Various Doxygen related 
> patches"  --suppress-from --compose 00*patch

As far as I can figure, you don't want to use the --thread option to git-format-patch when using git-send-email. However, I found git-send-email confusing enough that I just finished writing my own script to sit ontop of git-format-patch so I may be wrong ...

-- 
Julian

  ---
... relaxed in the manner of a man who has no need to put up a front of
any kind.
 		-- John Ball, "Mark One: the Dummy"

Johannes Schindelin· Mar 5, 2007, 02:25 UTC · re: Julian Phillips · lore

Re: Sending a thread of patches

Hi,

On Sun, 4 Mar 2007, Julian Phillips wrote:

> As far as I can figure, you don't want to use the --thread option to 
> git-format-patch when using git-send-email.

That might be true. However, I consider it a bug when git-send-email does not replace the In-Reply-To: header, but adds a second one.

Ciao, Dscho

Julian Phillips· Mar 5, 2007, 02:42 UTC · re: Johannes Schindelin · lore

Re: Sending a thread of patches

On Mon, 5 Mar 2007, Johannes Schindelin wrote:

Show 9 quoted lines

> Hi,
>
> On Sun, 4 Mar 2007, Julian Phillips wrote:
>
>> As far as I can figure, you don't want to use the --thread option to
>> git-format-patch when using git-send-email.
>
> That might be true. However, I consider it a bug when git-send-email does
> not replace the In-Reply-To: header, but adds a second one.

I wouldn't disagree with that.

FWIW, I seem to remember noticing that it did the same for References too ...

-- 
Julian

  ---
BOFH Excuse #323:

Your processor has processed too many instructions.  Turn it off immediately, do not type any commands!!