threads / patch / 7053

patch, 7 parts.git directory should be ignored

Subject: [PATCH 1/7] .git directory should be ignored

## tl;dr

4 messages between Mar 3, 2007 and Mar 5, 2007. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Xavier Maillard· Mar 3, 2007, 10:18 UTC · lore

Add .git to the list of extensions to be ignored

Signed-off-by: Xavier Maillard <zedek@gnu.org>
---
 contrib/emacs/vc-git.el |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Show changes to contrib/emacs/vc-git.el +3 −0

diff --git a/contrib/emacs/vc-git.el b/contrib/emacs/vc-git.el
index a2d3932..3d43ca0 100644
--- a/contrib/emacs/vc-git.el
+++ b/contrib/emacs/vc-git.el
@@ -149,4 +149,7 @@
 ;;    (and (looking-at "[0-9a-f]+")
 ;;         (buffer-substring (match-beginning 0) (match-end 0)))))
 
+;;;###autoload
+(add-to-list 'completion-ignored-extensions ".git/")
+
 (provide 'vc-git)

-- 
1.5.0

Junio C Hamano· Mar 3, 2007, 22:05 UTC · re: Xavier Maillard · lore

Re: [PATCH 1/7] .git directory should be ignored

Xavier Maillard <zedek@gnu.org> writes:

Show 19 quoted lines

> Add .git to the list of extensions to be ignored
>
> Signed-off-by: Xavier Maillard <zedek@gnu.org>
> ---
>  contrib/emacs/vc-git.el |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/contrib/emacs/vc-git.el b/contrib/emacs/vc-git.el
> index a2d3932..3d43ca0 100644
> --- a/contrib/emacs/vc-git.el
> +++ b/contrib/emacs/vc-git.el
> @@ -149,4 +149,7 @@
>  ;;    (and (looking-at "[0-9a-f]+")
>  ;;         (buffer-substring (match-beginning 0) (match-end 0)))))
>  
> +;;;###autoload
> +(add-to-list 'completion-ignored-extensions ".git/")
> +
>  (provide 'vc-git)

I am no Emacs vc expert to judge, but I wonder if it is kosher to muck with that global variable from a vc backend.

The above does mirror what pcl-cvs does for "CVS/" but I notice that vc-cvs.el does not do so, neither vc-rcs.el excludes "RCS/".

Alexandre Julliard· Mar 4, 2007, 22:02 UTC · re: Junio C Hamano · lore

Re: [PATCH 1/7] .git directory should be ignored

Junio C Hamano <junkio@cox.net> writes:

Show 6 quoted lines

> I am no Emacs vc expert to judge, but I wonder if it is kosher
> to muck with that global variable from a vc backend.
>
> The above does mirror what pcl-cvs does for "CVS/" but I notice
> that vc-cvs.el does not do so, neither vc-rcs.el excludes
> "RCS/".

Yes, I think if we really want to do this, it should be done in git.el, not in vc-git.

-- 
Alexandre Julliard
julliard@winehq.org

Xavier Maillard· Mar 5, 2007, 08:02 UTC · re: Junio C Hamano · lore

Re: [PATCH 1/7] .git directory should be ignored

   From: Junio C Hamano <junkio@cox.net>

   Xavier Maillard <zedek@gnu.org> writes:

   > Add .git to the list of extensions to be ignored
   The above does mirror what pcl-cvs does for "CVS/" but I notice
   that vc-cvs.el does not do so, neither vc-rcs.el excludes
   "RCS/".

Oops wrong file /o\. Iintended to do this into git.el... Please ignore. Iwill double-check my future contributions before sending it here.

Sorry

-- 
Xavier