[PATCH] git-archimport does not cope with empty summaries

Paolo Bonzini· Feb 27, 2007, 13:34 UTC · lore

I got this while importing bonzini@gnu.org--2004b/lightning--stable--1.2 (archive available at http://www.inf.unisi.ch/phd/bonzini/webdav/bonzini@gnu.org--2004b via webdav).

The patch seems pretty obvious to me:

2007-02-27  Paolo Bonzini  <bonzini@gnu.org>

         * git-archimport (parselog): Cope with an empty summary.

--- /usr/bin/git-archimport 2007-01-09 21:15:39.000000000 +0100 +++ ./git-archimport 2007-02-27 14:28:33.000000000 +0100

Show changes to diff +5 −1

@@ -780,7 +780,11 @@
      }

      # post-processing:
-    $ps->{summary} = join("\n",@{$ps->{summary}})."\n";
+    if (defined $ps->{summary}) {
+        $ps->{summary} = join("\n",@{$ps->{summary}})."\n";
+    } else {
+        $ps->{summary} = "empty summary\n";
+    }
      $ps->{message} = join("\n",@$log);

      # skip Arch control files, unescape pika-escaped files

patchgit-archimport does not cope with empty summaries