# [PATCH] builtin-fmt-merge-msg: fix bugs in --file option

1 messages from 2007-02-28 to 2007-02-28. Participants: Michael Coleman.
Thread: https://gitlist.dev/t/7011

## Michael Coleman, 2007-02-28 05:44

Subject: [PATCH] builtin-fmt-merge-msg: fix bugs in --file option
Message-ID: <1172641482207-git-send-email-tutufan@gmail.com>
URL: https://gitlist.dev/e/1172641482207-git-send-email-tutufan%40gmail.com

```
If --file's argument is missing, don't crash.  If it cannot be opened,
die with an error message.
---
 builtin-fmt-merge-msg.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/builtin-fmt-merge-msg.c b/builtin-fmt-merge-msg.c
index 1489883..5c145d2 100644
--- a/builtin-fmt-merge-msg.c
+++ b/builtin-fmt-merge-msg.c
@@ -259,13 +259,15 @@ int cmd_fmt_merge_msg(int argc, const char **argv, const char *prefix)
 		else if (!strcmp(argv[1], "--no-summary"))
 			merge_summary = 0;
 		else if (!strcmp(argv[1], "-F") || !strcmp(argv[1], "--file")) {
-			if (argc < 2)
+			if (argc < 3)
 				die ("Which file?");
 			if (!strcmp(argv[2], "-"))
 				in = stdin;
 			else {
 				fclose(in);
 				in = fopen(argv[2], "r");
+				if (!in)
+					die("cannot open %s", argv[2]);
 			}
 			argc--; argv++;
 		} else
-- 
1.5.0.rc3

```