threads / discuss / 6934

[COGITO] fix git-tag-ls in the presence of all-packed tags

Subject: [COGITO] fix git-tag-ls in the presence of all-packed tags

## tl;dr

One message between Feb 24, 2007 and Feb 24, 2007.

replies: 0people: 1as markdown or json

Nix· Feb 24, 2007, 00:07 UTC · lore

(I don't know if cogito is dead (no changes for two months), but on the off-chance that it isn't here's a tiny patch.)

Rely on the ref walker to determine if there are any tags. (Just consulting refs/tags fails wrongly if all tags are packed.)

Signed-off-by: Nick Alcock <nix@esperi.org.uk>
diff --git a/cg-tag-ls b/cg-tag-ls
index f4c776c..724f428 100755
--- a/cg-tag-ls
+++ b/cg-tag-ls
@@ -28,10 +28,7 @@ _git_wc_unneeded=1
 
 msg_no_tags="no tags present, please see cg-tag(1)"
 
-[ -d "$_git/refs/tags" ] || die "$msg_no_tags"
-
-[ "$(find "$_git/refs/tags" -follow -type f)" ] \
-       || die "$msg_no_tags"
+[ "x$(git-for-each-ref --count=1 --format=present refs/tags)" = "xpresent" ] || die "$msg_no_tags"
 
 maxlen="$(git-for-each-ref --format="%(refname)" refs/tags | column_width "refs/tags/")"
 
-- 
`In the future, company names will be a 32-character hex string.'
  --- Bruce Schneier on the shortage of company names

← back to recent threads