# [PATCH]: remove extra-verbosity from git-clone (http) 5 messages from 2007-02-15 to 2007-03-20. Participants: Fernando Herrera, Chris Wright, Junio C Hamano. Thread: https://gitlist.dev/t/6834 ## Fernando Herrera, 2007-02-15 17:10 Subject: [PATCH]: remove extra-verbosity from git-clone (http) Message-ID: <58d389c20702150910x24ec218bjdb9cb49ee03fd1df@mail.gmail.com> URL: https://gitlist.dev/e/58d389c20702150910x24ec218bjdb9cb49ee03fd1df%40mail.gmail.com ``` Hi, the attached patch removes the extra verbosity when cloning a http repository. I noticed this after some git upgrade in fedora. Please, consider applying it, getting tons of "got XXX", "walk XXX" lines by default is a little bit annoying. Salu2 PS: Thanks for this so great piece os software! --- git-clone.sh.orig 2007-02-15 19:03:51.000000000 +0200 +++ git-clone.sh 2007-02-15 19:04:06.000000000 +0200 @@ -59,7 +59,7 @@ else tname=$name fi - git-http-fetch -v -a -w "$tname" "$name" "$1/" || exit 1 + git-http-fetch -a -w "$tname" "$name" "$1/" || exit 1 done <"$clone_tmp/refs" rm -fr "$clone_tmp" http_fetch "$1/HEAD" "$GIT_DIR/REMOTE_HEAD" || ``` ## Chris Wright, 2007-03-19 23:04 Subject: Re: [PATCH]: remove extra-verbosity from git-clone (http) Message-ID: <20070319230436.GB12555@sequoia.sous-sol.org> URL: https://gitlist.dev/e/20070319230436.GB12555%40sequoia.sous-sol.org In-Reply-To: <58d389c20702150910x24ec218bjdb9cb49ee03fd1df@mail.gmail.com> ``` * Fernando Herrera (fherrera@onirica.com) wrote: > the attached patch removes the extra verbosity when cloning a http > repository. I noticed this after some git upgrade in fedora. Please, > consider applying it, getting tons of "got XXX", "walk XXX" lines by > default is a little bit annoying. > > Salu2 > > PS: Thanks for this so great piece os software! > > --- git-clone.sh.orig 2007-02-15 19:03:51.000000000 +0200 > +++ git-clone.sh 2007-02-15 19:04:06.000000000 +0200 > @@ -59,7 +59,7 @@ > else > tname=$name > fi > - git-http-fetch -v -a -w "$tname" "$name" "$1/" || exit 1 > + git-http-fetch -a -w "$tname" "$name" "$1/" || exit 1 > done <"$clone_tmp/refs" > rm -fr "$clone_tmp" > http_fetch "$1/HEAD" "$GIT_DIR/REMOTE_HEAD" || Was there any problem with this patch from Fernando? I don't care much either way (I simply never use http fetch myself ;-). Just doing some old bugzilla cleanup and noticed this still was neither picked up nor replied to. So, in case it just fell through the cracks... thanks, -chris ``` ## Junio C Hamano, 2007-03-19 23:45 Subject: Re: [PATCH]: remove extra-verbosity from git-clone (http) Message-ID: <7vslc0er1e.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vslc0er1e.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20070319230436.GB12555@sequoia.sous-sol.org> ``` Chris Wright writes: > * Fernando Herrera (fherrera@onirica.com) wrote: >> the attached patch removes the extra verbosity when cloning a http >> repository. I noticed this after some git upgrade in fedora. Please, >> consider applying it, getting tons of "got XXX", "walk XXX" lines by >> default is a little bit annoying. >> >> Salu2 >> >> PS: Thanks for this so great piece os software! >> >> --- git-clone.sh.orig 2007-02-15 19:03:51.000000000 +0200 >> +++ git-clone.sh 2007-02-15 19:04:06.000000000 +0200 >> @@ -59,7 +59,7 @@ >> else >> tname=$name >> fi >> - git-http-fetch -v -a -w "$tname" "$name" "$1/" || exit 1 >> + git-http-fetch -a -w "$tname" "$name" "$1/" || exit 1 >> done <"$clone_tmp/refs" >> rm -fr "$clone_tmp" >> http_fetch "$1/HEAD" "$GIT_DIR/REMOTE_HEAD" || > > Was there any problem with this patch from Fernando? I don't care much > either way (I simply never use http fetch myself ;-). Just doing some > old bugzilla cleanup and noticed this still was neither picked up nor > replied to. So, in case it just fell through the cracks... I saw it. The -v option used not to be there, but we added it with an explicit purpose of not boring people fetching over http connection (which used to be slow especially before packfiles were introduced). I do not care much either way, but I suspect there actually are people who want to see that "assuring look" of something happening. I dunno. I am certainly *not* opposed to have an explicit option or a per-user configuration to make it not pass -v to http-fetch. I am just wondering if we want to change the default. Especially people new to git may wonder what is happening without _any_ feedback if we turned it off by default. ``` ## Chris Wright, 2007-03-20 02:18 Subject: Re: [PATCH]: remove extra-verbosity from git-clone (http) Message-ID: <20070320021818.GG10574@sequoia.sous-sol.org> URL: https://gitlist.dev/e/20070320021818.GG10574%40sequoia.sous-sol.org In-Reply-To: <7vslc0er1e.fsf@assigned-by-dhcp.cox.net> ``` * Junio C Hamano (junkio@cox.net) wrote: > I saw it. The -v option used not to be there, but we added it > with an explicit purpose of not boring people fetching over http > connection (which used to be slow especially before packfiles > were introduced). I do not care much either way, but I suspect > there actually are people who want to see that "assuring look" > of something happening. I dunno. Actually, I very much agree now that I've actually tried it myself when testing the simple patch below. > I am certainly *not* opposed to have an explicit option or a > per-user configuration to make it not pass -v to http-fetch. I > am just wondering if we want to change the default. Especially > people new to git may wonder what is happening without _any_ > feedback if we turned it off by default. Well, there's enough to go on already. So how about this simple change for those few that are bothered by the verbose output? Works in my basic testing. thanks, -chris -- Subject: [PATCH] make git clone -q suppress the noise with http fetch We already have -q in git clone. So for those who care to suppress the noise during an http based clone, make -q actually do a quiet http fetch. Signed-off-by: Chris Wright Cc: Fernando Herrera --- git-clone.sh | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/git-clone.sh b/git-clone.sh index 1bd54de..ab6c5c0 100755 --- a/git-clone.sh +++ b/git-clone.sh @@ -42,6 +42,7 @@ clone_dumb_http () { http_fetch "$1/info/refs" "$clone_tmp/refs" || die "Cannot get remote repository information. Perhaps git-update-server-info needs to be run there?" + test "z$quiet" = z && v=-v || v= while read sha1 refname do name=`expr "z$refname" : 'zrefs/\(.*\)'` && @@ -59,7 +60,7 @@ Perhaps git-update-server-info needs to be run there?" else tname=$name fi - git-http-fetch -v -a -w "$tname" "$name" "$1/" || exit 1 + git-http-fetch $v -a -w "$tname" "$name" "$1/" || exit 1 done <"$clone_tmp/refs" rm -fr "$clone_tmp" http_fetch "$1/HEAD" "$GIT_DIR/REMOTE_HEAD" || ``` ## Junio C Hamano, 2007-03-20 06:46 Subject: Re: [PATCH]: remove extra-verbosity from git-clone (http) Message-ID: <7vtzwg9zuc.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vtzwg9zuc.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20070320021818.GG10574@sequoia.sous-sol.org> ``` Sounds sane. Thanks. ```